Bugfix/comscore improvements #27
Conversation
🦋 Changeset detectedLatest commit: 955b853 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wjoosen
force-pushed
the
bugfix/comscore-improvements
branch
from
9582bfe
to
eab424d
Compare
comscore/README.md
Outdated
| // Execute a function with platform-specific code to retrieve up-to-date information. | ||
| runPlatformSpecificCodeToRetrieveValues(onSuccessCallback, onErrorCallback); | ||
| } | ||
| // |
There was a problem hiding this comment.
Empty comment can be removed
| console.log( | ||
| `[COMSCORE - StreamingAnalytics] startFromDvrWindowOffset ${this.dvrWindowOffsetMs}` | ||
| ); | ||
| } |
There was a problem hiding this comment.
Can maybe include this in a more general setContentMetadata and/or make a separate function for it since it is duplicated below as well?
There was a problem hiding this comment.
Decided to leave it out of setContentMetadata (since it only prepares the metadata object and interacts with only one StreamingAnalyics api) but extracted it to a separate function
| private isBeforePreRoll = (): boolean => | ||
| this.player.ads?.scheduledAdBreaks.length ? this.player.ads?.scheduledAdBreaks[0].timeOffset === 0 : false; | ||
| private isBeforePreRoll = (): boolean => { | ||
| const hasScheduledAdBreaks = this.player.ads?.scheduledAdBreaks.length !== 0; |
There was a problem hiding this comment.
Can player.ads ever be undefined here? Might want to add an early return if that's the case?
A variety of improvements to the comscore connector: