-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/comscore improvements #27
Merged
Merged
Changes from 23 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
7ea36be
open existing test page in serve script
wjoosen 8dd5dfe
provide ad duration in milliseconds
wjoosen c4ddb31
use rounded amount of milliseconds
wjoosen 9d53084
catch undefined ad durations before conversion to ms
wjoosen 75a512d
use rounded amount of milliseconds when reporting new playback position
wjoosen 234d418
store the built ContentMetadata object in contentMetadata property
wjoosen 20ebeb1
call notifyEnd and set new ad metadata after each ad
wjoosen 9da96d0
introduce dvr window related properties
wjoosen bd490c0
store dvr window offset in ms
wjoosen c243056
store dvr window length in ms
wjoosen eab424d
report dvr window properties to comscore after setting main content m…
wjoosen e67c032
add changesets
wjoosen e40bdfa
Accept ComscoreConfiguration property to set the platform api
wjoosen 173bfc0
add platform api example
wjoosen bfc6701
add changeset
wjoosen 6180f4b
Extend README
wjoosen c4c6913
Fix typedoc warning
wjoosen d5703f7
use mapped platform api type
wjoosen d6b8e54
include tizen platform api
wjoosen 04c4c9c
add changeset for missing related content metadata bugfix
wjoosen 12f4d81
only ignore playing events before pre-roll breaks that have ads
wjoosen 8b29b08
prettier
wjoosen ef6bfa3
add changeset for empty pre-roll issue
wjoosen 04e1f18
remove empty comment
wjoosen 56415d9
return early if the ads feature is not enabled on the player sdk
wjoosen 955b853
separate function for setting dvr window length and offset
wjoosen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@theoplayer/comscore-connector-web": patch | ||
--- | ||
|
||
Fixed an issue where DVR window length and offsets were incorrectly reported. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@theoplayer/comscore-connector-web": patch | ||
--- | ||
|
||
Fixed an issue where playhead positions or content/ad durations were not reported in (rounded) milliseconds. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@theoplayer/comscore-connector-web": patch | ||
--- | ||
|
||
Fixed an issue where only one ad in an adbreak would be reported. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@theoplayer/comscore-connector-web": patch | ||
--- | ||
|
||
Fixed an issue where playback of the main content wouldn't get reported if Google IMA returned an empty pre-roll ad break. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@theoplayer/comscore-connector-web": patch | ||
--- | ||
|
||
Fixed an issue where no content metadata was reported during a pre-roll ad. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@theoplayer/comscore-connector-web": minor | ||
--- | ||
|
||
Add the option to inform the ComScore library of the environment it is running in through the `setPlatformAPI`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty comment can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅