oopt-tai/inc:Add enum for modulation-format #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ishidawataru -san, please check this pull request. |
|
@hongliMurphy Sorry for the delay. Could you add a comment on what PS stands for? Also, does it make sense to add probabilistic shaping variants for other modulation formats? |
hongliMurphy
force-pushed
the
feature/add_modulation_format_enum_for_PCS
branch
from
2e27899
to
3b0e679
Compare
Ishida-san, updated with comment. I am checking with Catherine on which ones can have the PS variant. |
hongliMurphy
force-pushed
the
feature/add_modulation_format_enum_for_PCS
branch
from
3b0e679
to
3ed907e
Compare
hongliMurphy
force-pushed
the
feature/add_modulation_format_enum_for_PCS
branch
from
3ed907e
to
5ea1659
Compare
|
@ishidawataru san, I consulted with Catherine-san and FLA team, the probabilistic shaping is not applicable to lower level modulation-format. So I added PS for DP-32-QAM, and DP-64-QAM. Please check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add DP_16_QAM_PS in modulation-format, and also none to fec-type