Feature: Cake Day #1042
Open
Feature: Cake Day #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christolis
force-pushed
the
feature/cake-day
branch
from
60b2118
to
c7bff99
Compare
SquidXTV
requested changes
Mar 5, 2024
application/src/main/java/org/togetherjava/tjbot/config/Config.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/cakeday/CakeDayService.java
Outdated
Show resolved
Hide resolved
SquidXTV
requested changes
Mar 6, 2024
application/src/main/java/org/togetherjava/tjbot/config/CakeDayConfig.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/cakeday/CakeDayService.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/cakeday/CakeDayService.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/cakeday/CakeDayService.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/cakeday/CakeDayService.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/cakeday/CakeDayService.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/cakeday/CakeDayService.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/cakeday/CakeDayService.java
Show resolved
Hide resolved
SquidXTV
previously approved these changes
Mar 6, 2024
|
It would be nice if one of the @Together-Java/moderators can review some of the critical parts of this feature when you can. |
tj-wazei
reviewed
Mar 17, 2024
application/src/main/java/org/togetherjava/tjbot/features/cakeday/CakeDayListener.java
Show resolved
Hide resolved
christolis
force-pushed
the
feature/cake-day
branch
from
d8c7206
to
20886ad
Compare
christolis
force-pushed
the
feature/cake-day
branch
from
20886ad
to
eab0bdf
Compare
Co-authored-by: TheCodeMr <151576372+TheCodeMr@users.noreply.github.com> Co-authored-by: cab <161495905+cabagbe@users.noreply.github.com> Co-authored-by: Devansh Tiwari <65783463+devloves@users.noreply.github.com>
This commit aims to fix a bug where the CakeDayService#addTodayMembersCakeDayRole() method would add the cake day role to all members who have been at least one year into the server, disregarding the month and date in which they joined. The documentation has also been made more clean and concise, while the CakeDayService#addCakeDayRole() which required a UserSnowflake as one of its inputs has been removed and now the other version of this function is used which only requires a Member instance. Passing the Guild would be unnecessary as it could be easily acquired from the Member instance, and additionally it helps make sure that the right Member and Guild are used to call this method. Finally, this commit adds an extra condition in the select-from query found in CakeDayService#findCakeDaysTodayFromDatabase() which makes sure that we get all the cake days for the right guild, instead of getting them all unconditionally.
christolis
force-pushed
the
feature/cake-day
branch
from
eab0bdf
to
e98eb35
Compare
ankitsmt211
added
the
config-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that this is not a certain feature to be added, but I still wanted to experiment and see what I could come up with :)
Description
This pull request introduces the addition of the cake day feature to the server, allowing members to commemorate their annual membership anniversary with a unique "Cake day" role, with which they can celebrate within the community.
This feature uses the database and makes a
cake_daystable in order to store each member's joined date, as well the guild in which they joined (in case the bot ever gets to handle multiple guilds). The date stored in the database is split into two columns: the month and the day in one (joined_month_day), and the year in an other (joined_year). The reason the join date is split into these two columns is so that an index can be added for thejoined_month_daycolumn in order to make reading from the database faster. Therefore, it will be easier for the bot to find all cake days by the month and day, a search that would occur daily by this feature's routine.If the bot finds that the
cake_daystable has no records, then it attempts to populate the table from all members of all guilds in a separate thread with batched insert queries in order to optimize the table population task.Configuration changes
cakeDayConfig.rolePatternrole to give to members.
"Cake Day"Diagram
TODO
0, assign them the role and whatever cosmetic stuff necessary.Closes #1035.