-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Cake Day #1042
Open
christolis
wants to merge
15
commits into
Together-Java:develop
Choose a base branch
from
christolis:feature/cake-day
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature: Cake Day #1042
Commits on May 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 227441d - Browse repository at this point
Copy the full SHA 227441dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a6e92c - Browse repository at this point
Copy the full SHA 4a6e92cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b635f0 - Browse repository at this point
Copy the full SHA 5b635f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 658a847 - Browse repository at this point
Copy the full SHA 658a847View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e6a8c2 - Browse repository at this point
Copy the full SHA 6e6a8c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3092e94 - Browse repository at this point
Copy the full SHA 3092e94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57c1ffd - Browse repository at this point
Copy the full SHA 57c1ffdView commit details -
fix: include anniversary logic for cake day
Co-authored-by: TheCodeMr <151576372+TheCodeMr@users.noreply.github.com> Co-authored-by: cab <161495905+cabagbe@users.noreply.github.com> Co-authored-by: Devansh Tiwari <65783463+devloves@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 6f97278 - Browse repository at this point
Copy the full SHA 6f97278View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9228417 - Browse repository at this point
Copy the full SHA 9228417View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b47108 - Browse repository at this point
Copy the full SHA 2b47108View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc318f6 - Browse repository at this point
Copy the full SHA dc318f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea06646 - Browse repository at this point
Copy the full SHA ea06646View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ae61d2 - Browse repository at this point
Copy the full SHA 8ae61d2View commit details -
fix(CakeDayService): consider month and day for cake day role
This commit aims to fix a bug where the CakeDayService#addTodayMembersCakeDayRole() method would add the cake day role to all members who have been at least one year into the server, disregarding the month and date in which they joined. The documentation has also been made more clean and concise, while the CakeDayService#addCakeDayRole() which required a UserSnowflake as one of its inputs has been removed and now the other version of this function is used which only requires a Member instance. Passing the Guild would be unnecessary as it could be easily acquired from the Member instance, and additionally it helps make sure that the right Member and Guild are used to call this method. Finally, this commit adds an extra condition in the select-from query found in CakeDayService#findCakeDaysTodayFromDatabase() which makes sure that we get all the cake days for the right guild, instead of getting them all unconditionally.
Configuration menu - View commit details
-
Copy full SHA for 0502f83 - Browse repository at this point
Copy the full SHA 0502f83View commit details -
Configuration menu - View commit details
-
Copy full SHA for e98eb35 - Browse repository at this point
Copy the full SHA e98eb35View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.