Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Cake Day #1042

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Feature: Cake Day #1042

wants to merge 15 commits into from

Commits on May 17, 2024

  1. feat(cake-day): implement batch insert cake days routine

    @christolis
    christolis committed May 17, 2024
    Configuration menu
    Copy the full SHA
    227441d View commit details
    Browse the repository at this point in the history

  2. feat(cake-day): implement actual routine logic

    @christolis
    christolis committed May 17, 2024
    Configuration menu
    Copy the full SHA
    4a6e92c View commit details
    Browse the repository at this point in the history

  3. docs: add JavaDocs

    @christolis
    christolis committed May 17, 2024
    Configuration menu
    Copy the full SHA
    5b635f0 View commit details
    Browse the repository at this point in the history

  4. refactor: move cake day feature to its own directory

    @christolis
    christolis committed May 17, 2024
    Configuration menu
    Copy the full SHA
    658a847 View commit details
    Browse the repository at this point in the history

  5. fix: improve role refresh handling and make it work

    @christolis
    christolis committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6e6a8c2 View commit details
    Browse the repository at this point in the history

  6. refactor: remove unused method

    @christolis
    christolis committed May 17, 2024
    Configuration menu
    Copy the full SHA
    3092e94 View commit details
    Browse the repository at this point in the history

  7. docs: add JavaDocs

    @christolis
    christolis committed May 17, 2024
    Configuration menu
    Copy the full SHA
    57c1ffd View commit details
    Browse the repository at this point in the history

  8. fix: include anniversary logic for cake day 

    Co-authored-by: TheCodeMr <151576372+TheCodeMr@users.noreply.github.com>
Co-authored-by: cab <161495905+cabagbe@users.noreply.github.com>
Co-authored-by: Devansh Tiwari <65783463+devloves@users.noreply.github.com>
    @christolis @TheCodeMr
    @cabagbe @devloves
    4 people committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6f97278 View commit details
    Browse the repository at this point in the history

  9. fix: add Objects#requireNonNull() on cakeDayConfig

    @christolis
    christolis committed May 17, 2024
    Configuration menu
    Copy the full SHA
    9228417 View commit details
    Browse the repository at this point in the history

  10. feat(config): add proper default value for key

    @christolis
    christolis committed May 17, 2024
    Configuration menu
    Copy the full SHA
    2b47108 View commit details
    Browse the repository at this point in the history

  11. feat(cake-day): improve removeRoleFromMembers() method

    @christolis
    christolis committed May 17, 2024
    Configuration menu
    Copy the full SHA
    dc318f6 View commit details
    Browse the repository at this point in the history

  12. feat: add CakeDayConfig record constructor

    @christolis
    christolis committed May 17, 2024
    Configuration menu
    Copy the full SHA
    ea06646 View commit details
    Browse the repository at this point in the history

  13. feat: use Optional properly

    @christolis
    christolis committed May 17, 2024
    Configuration menu
    Copy the full SHA
    8ae61d2 View commit details
    Browse the repository at this point in the history

  14. fix(CakeDayService): consider month and day for cake day role 

    This commit aims to fix a bug where the
CakeDayService#addTodayMembersCakeDayRole() method would add the cake day
role to all members who have been at least one year into the server,
disregarding the month and date in which they joined.

The documentation has also been made more clean and concise, while the
CakeDayService#addCakeDayRole() which required a UserSnowflake as one of
its inputs has been removed and now the other version of this function
is used which only requires a Member instance. Passing the Guild would
be unnecessary as it could be easily acquired from the Member instance,
and additionally it helps make sure that the right Member and Guild are
used to call this method.

Finally, this commit adds an extra condition in the select-from query
found in CakeDayService#findCakeDaysTodayFromDatabase() which makes sure
that we get all the cake days for the right guild, instead of getting
them all unconditionally.
    @christolis
    christolis committed May 17, 2024
    Configuration menu
    Copy the full SHA
    0502f83 View commit details
    Browse the repository at this point in the history

  15. refactor: better use of Optional

    @christolis
    christolis committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e98eb35 View commit details
    Browse the repository at this point in the history