Tests #14
Draft
Tests #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR:
The tests have been failing basically since the inception of this repo. This branch aims to fix that. The fun part: the tests don't work on my machine, but it's entirely possible they do work on the CD "machine", so I need to leave this PR here to trigger the tests while I work.
For now, the solution is to add
# type: ignoreto the end of every single import statement. Once that's done, other errors will reveal themselves. But for the time being, even though this isn't what should need to happen, this is what's happening. The other solution is to add consistent and diligent typing to the entire project, but considering I'm working on a time crunch, I chose the faster and less-good solution.