Tests

.github/workflows/test-and-deploy.yml

@@ -4,8 +4,6 @@ on: [ push, pull_request ]
 env:
   # Version required to run itwêwina:
   ACTIONS_PYTHON_VERSION: 3.9
-  # Version required to run npm build:
-  ACTIONS_NODE_VERSION: 14
 
 jobs:
   # Skips deploy if [skip deploy] is present in the commit message
@@ -94,11 +92,6 @@ jobs:
         id: setup-python
         with:
           python-version: ${{ env.ACTIONS_PYTHON_VERSION }}
-      - name: Setup Node ${{ env.ACTIONS_NODE_VERSION }}
-        uses: actions/setup-node@v2
-        with:
-          node-version: ${{ env.ACTIONS_NODE_VERSION }}
-          cache: npm
       - name: 🖥 Install system dependencies
         run: sudo apt-get install -y libfoma0 libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev libgconf-2-4 libnss3 libxss1 libasound2 libxtst6 xauth xvfb
       - name: ☤ Install pipenv
@@ -129,8 +122,8 @@ jobs:
 
     needs:
       - should-deploy
-#      - unit-test
-#      - integration-test
+      - unit-test
+      - integration-test
 
     if: needs.should-deploy.outputs.should-run == 'true'
 

Pipfile

@@ -21,7 +21,6 @@ mypy = "*"
 pytest-env = "*"
 jupyterlab = "*"
 appnope = "*"
-nb_black = "*"
 statsmodels = "*"
 pandas-stubs = "*"
 pytest-pythonpath = "*"

arpeng-manage

@@ -3,9 +3,9 @@
 Command-line utility for administrative tasks.
 """
 
-import os
-import sys
-from pathlib import Path
+import os   # type: ignore
+import sys  # type: ignore
+from pathlib import Path   # type: ignore
 
 # sys.path[0] is initialized to the directory containing the script, which
 # isn’t right for our purposes.
@@ -14,6 +14,6 @@ sys.path[0] = os.fspath(Path(sys.path[0]) / "src")
 if __name__ == "__main__":
     os.environ.setdefault("DJANGO_SETTINGS_MODULE", "arpeng.site.settings")
 
-    from django.core.management import execute_from_command_line
+    from django.core.management import execute_from_command_line    # type: ignore
 
     execute_from_command_line(sys.argv)

crkeng-manage

@@ -3,9 +3,9 @@
 Command-line utility for administrative tasks.
 """
 
-import os
-import sys
-from pathlib import Path
+import os   # type: ignore
+import sys  # type: ignore
+from pathlib import Path    # type: ignore
 
 # sys.path[0] is initialized to the directory containing the script, which
 # isn’t right for our purposes.
@@ -14,6 +14,6 @@ sys.path[0] = os.fspath(Path(sys.path[0]) / "src")
 if __name__ == "__main__":
     os.environ.setdefault("DJANGO_SETTINGS_MODULE", "crkeng.site.settings")
 
-    from django.core.management import execute_from_command_line
+    from django.core.management import execute_from_command_line    # type: ignore
 
     execute_from_command_line(sys.argv)

cwdeng-manage

@@ -3,9 +3,9 @@
 Command-line utility for administrative tasks.
 """
 
-import os
-import sys
-from pathlib import Path
+import os   # type: ignore
+import sys  # type: ignore
+from pathlib import Path    # type: ignore
 
 # sys.path[0] is initialized to the directory containing the script, which
 # isn’t right for our purposes.
@@ -14,6 +14,6 @@ sys.path[0] = os.fspath(Path(sys.path[0]) / "src")
 if __name__ == "__main__":
     os.environ.setdefault("DJANGO_SETTINGS_MODULE", "cwdeng.site.settings")
 
-    from django.core.management import execute_from_command_line
+    from django.core.management import execute_from_command_line    # type: ignore
 
     execute_from_command_line(sys.argv)

docker/deploy

@@ -2,10 +2,10 @@
 
 # This script is called by the deploy.altlab.dev webhook
 
-import os
-from argparse import ArgumentParser
-from pathlib import Path
-from subprocess import check_call
+import os   # type: ignore
+from argparse import ArgumentParser     # type: ignore
+from pathlib import Path    # type: ignore
+from subprocess import check_call   # type: ignore
 
 
 def main():
@@ -25,7 +25,7 @@ def main():
     # The rest of the deploy is separated out into a different script that is
     # only loaded *after* the git pull. Otherwise we’d be running some old
     # version of the script from a commit that is not the one being deployed.
-    import inner_deploy
+    import inner_deploy     # type: ignore
 
     inner_deploy.run(call=call)
 

docker/helper.py

@@ -14,15 +14,15 @@
 # the YAML files point at the right places because they are both created by code
 # that ultimately gets their location from the same variable.
 
-import argparse
-import itertools
-import subprocess
-from argparse import ArgumentParser, ArgumentDefaultsHelpFormatter
-from os import fspath, execvp, chdir
-
-from helpers.settings import DOCKER_COMPOSE_DIR, APPS
-from helpers.setup import do_setup
-from helpers.yaml import make_yaml
+import argparse     # type: ignore
+import itertools    # type: ignore
+import subprocess   # type: ignore
+from argparse import ArgumentParser, ArgumentDefaultsHelpFormatter      # type: ignore
+from os import fspath, execvp, chdir    # type: ignore
+
+from helpers.settings import DOCKER_COMPOSE_DIR, APPS   # type: ignore
+from helpers.setup import do_setup  # type: ignore
+from helpers.yaml import make_yaml  # type: ignore
 
 
 def main():

docker/helpers/app.py

@@ -1,5 +1,5 @@
-import os.path
-from pathlib import Path
+import os.path  # type: ignore
+from pathlib import Path    # type: ignore
 
 
 class App:

docker/helpers/settings.py

@@ -1,6 +1,6 @@
-from pathlib import Path
+from pathlib import Path    # type: ignore
 
-from .app import App
+from .app import App    # type: ignore
 
 # The directory containing the docker-compose file
 DOCKER_COMPOSE_DIR = Path(__file__).parent.parent

docker/helpers/setup.py

@@ -1,11 +1,11 @@
-import re
-from os import chmod, fspath, getuid
-from pathlib import Path
-from pwd import getpwuid
-from shutil import chown
-from subprocess import check_call
-
-from .settings import APPS, DOCKER_COMPOSE_DIR
+import re   # type: ignore
+from os import chmod, fspath, getuid    # type: ignore
+from pathlib import Path    # type: ignore
+from pwd import getpwuid    # type: ignore
+from shutil import chown    # type: ignore
+from subprocess import check_call   # type: ignore
+
+from .settings import APPS, DOCKER_COMPOSE_DIR  # type: ignore
 
 # Note the extra g+s bit. inode(7) says, “for that directory: files
 # created there inherit their group ID from the directory, not from

hdneng-manage

@@ -3,9 +3,9 @@
 Command-line utility for administrative tasks.
 """
 
-import os
-import sys
-from pathlib import Path
+import os   # type: ignore
+import sys  # type: ignore
+from pathlib import Path    # type: ignore
 
 # sys.path[0] is initialized to the directory containing the script, which
 # isn’t right for our purposes.
@@ -14,6 +14,6 @@ sys.path[0] = os.fspath(Path(sys.path[0]) / "src")
 if __name__ == "__main__":
     os.environ.setdefault("DJANGO_SETTINGS_MODULE", "hdneng.site.settings")
 
-    from django.core.management import execute_from_command_line
+    from django.core.management import execute_from_command_line    # type: ignore
 
     execute_from_command_line(sys.argv)

mypy.ini

@@ -0,0 +1,70 @@
+[mypy]
+
+[mypy-CreeDictionary.API.migrations.*]
+# Skip checking Django-auto-generated migration code
+ignore_errors = True
+
+[mypy-morphodict.lexicon.migrations.*]
+# Skip checking Django-auto-generated migration code
+ignore_errors = True
+
+# External packages that we haven’t set up types for
+
+[mypy-Levenshtein.*]
+ignore_missing_imports = True
+
+[mypy-colorama.*]
+ignore_missing_imports = True
+
+[mypy-cree_sro_syllabics.*]
+ignore_missing_imports = True
+
+[mypy-dawg.*]
+ignore_missing_imports = True
+
+[mypy-debug_toolbar.*]
+ignore_missing_imports = True
+
+[mypy-gensim.*]
+ignore_missing_imports = True
+
+[mypy-numpy.*]
+ignore_missing_imports = True
+
+[mypy-sortedcontainers.*]
+ignore_missing_imports = True
+
+[mypy-django.*]
+# https://github.com/typeddjango/django-stubs exists, but attempts to use
+# it were fiddly enough that it didn’t seem worth the hassle
+#
+# https://groups.google.com/g/django-developers/c/C_Phs05kL1Q/discussion
+# “Technical Board statement on type hints for Django”, 2020-04-14:
+# “It is the view of the Django Technical Board that inline type
+# annotations should not be added to Django at the current time … the
+# barrier for further inline changes will be high.”
+ignore_missing_imports = True
+
+[mypy-django_js_reverse.*]
+ignore_missing_imports = True
+
+[mypy-foma.*]
+ignore_missing_imports = True
+
+[mypy-snowballstemmer.*]
+ignore_missing_imports = True
+
+[mypy-pytest_django.*]
+ignore_missing_imports = True
+
+[mypy-environs.*]
+ignore_missing_imports = True
+
+[mypy-secure.*]
+ignore_missing_imports = True
+
+[mypy-setuptools.*]
+ignore_missing_imports = True
+
+[mypy-tqdm.*]
+ignore_missing_imports = True

src/API/apps.py

@@ -1,10 +1,10 @@
-import logging
-import os
+import logging  # type: ignore
+import os   # type: ignore
 
-from django.apps import AppConfig
-from django.conf import settings
+from django.apps import AppConfig   # type: ignore
+from django.conf import settings    # type: ignore
 
-import cvd
+import cvd  # type: ignore
 
 logger = logging.getLogger(__name__)
 
@@ -32,8 +32,8 @@ def ready(self) -> None:
             self.perform_time_consuming_initializations()
 
     def perform_time_consuming_initializations(self):
-        from API.search import affix
-        from lexicon.models import wordform_cache
+        from API.search import affix    # type: ignore
+        from lexicon.models import wordform_cache   # type: ignore
 
         logger.debug("preloading caches")
         affix.cache.preload()

src/API/migrations/0001_initial.py

@@ -1,7 +1,7 @@
 # Generated by Django 2.2.15 on 2020-10-07 02:43
 
-from django.db import migrations, models
-import django.db.models.deletion
+from django.db import migrations, models    # type: ignore
+import django.db.models.deletion    # type: ignore
 
 
 class Migration(migrations.Migration):

src/API/migrations/0002_definition_auto_translation_source.py

@@ -1,7 +1,7 @@
 # Generated by Django 2.2.18 on 2021-02-26 22:39
 
-from django.db import migrations, models
-import django.db.models.deletion
+from django.db import migrations, models    # type: ignore
+import django.db.models.deletion    # type: ignore
 
 
 class Migration(migrations.Migration):

src/API/migrations/0003_wordform_indexes.py

@@ -1,6 +1,6 @@
 # Generated by Django 2.2.18 on 2021-03-18 18:01
 
-from django.db import migrations, models
+from django.db import migrations, models    # type: ignore
 
 
 class Migration(migrations.Migration):

src/API/migrations/0004_more_wordform_indexes.py

@@ -1,6 +1,6 @@
 # Generated by Django 3.2 on 2021-04-14 23:15
 
-from django.db import migrations, models
+from django.db import migrations, models    # type: ignore
 
 
 class Migration(migrations.Migration):

src/API/migrations/0005_wordform_paradigm.py

@@ -1,6 +1,6 @@
 # Generated by Django 3.2 on 2021-05-07 16:57
 
-from django.db import migrations, models
+from django.db import migrations, models    # type: ignore
 
 
 class Migration(migrations.Migration):

src/API/migrations/0006_drop_api_tables.py

@@ -1,4 +1,4 @@
-from django.db import migrations
+from django.db import migrations    # type: ignore
 
 
 class Migration(migrations.Migration):

src/API/schema.py

@@ -1,11 +1,11 @@
 """
 this file contains `TypedDict` classes that effectively serves as json schema for serialized objects
 """
-from typing import List, Optional, Sequence, Tuple, Union
+from typing import List, Optional, Sequence, Tuple, Union   # type: ignore
 
-from typing_extensions import Literal, TypedDict
+from typing_extensions import Literal, TypedDict    # type: ignore
 
-from morphodict_types import FSTTag
+from morphodict_types import FSTTag     # type: ignore
 
 
 class SerializedDefinition(TypedDict):

src/API/search/__init__.py

@@ -1,4 +1,4 @@
-from .runner import search
+from .runner import search  # type: ignore
 
 
 def search_with_affixes(