Boolean logic error in LayerPlan::computeCombBoundary #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is infill OR anti_overhang, not if mesh is infill AND anti_overhang.
github-actions
bot
added
the
PR: Community Contribution 👑
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is infill OR anti_overhang, not if mesh is
infill AND anti_overhang.
Description
Previously the comb boundary was not calculated if the mesh was both an infill_mesh AND an anti_overhang_mesh.
I'm quite sure that it was intended for this to in fact be if the mesh was either an infill_mesh OR an anti_overhang mesh.
Type of change
How Has This Been Tested?
I have ran cura with the relevant changes and seen no untoward effects. To be fair, I had not seen any untoward effects before the changes either.
Test Configuration:
Checklist: