MFileZip fixes #1345
Merged
MFileZip fixes #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdrwenski
force-pushed
the
mfilezip-fixes
branch
2 times, most recently
from
09df8bf
to
a95b04e
Compare
haileyajohnson
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Several issues with
MFileZiphave come to light since it has been incorporated in the TDS as part of the zarr code. This PR fixes these and adds some unit tests.getLastModifiedandgetLengthfor the root zip file to not return 0writeToStreamto work the same as it would for aMFileOSisZipFiletoMFileinterface. In the TDS, the fileServer should allow downloading zips but disallow downloading directories.MFileZips can be considered directories. So we need a way to distinguish between directories and zip files. This is what I came up with but we could also consider changingisDirectoryor doing something else. See Fix issue with zip files being disallowed with fileServer tds#501 for proposed TDS change.