Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with zip files being disallowed with fileServer #501

Merged
merged 5 commits into from
May 23, 2024
Merged

Fix issue with zip files being disallowed with fileServer #501

merged 5 commits into from
May 23, 2024

Conversation

tdrwenski
Copy link
Contributor

Depends on Unidata/netcdf-java#1345 to compile. Since MFileZip has been added to the TDS via the zarr code, zip files will be opened with that class, and can be considered directories.

This PR:

  • the check to disallow directories to be downloaded with fileServer now allows zips
  • add tests

@tdrwenski tdrwenski mentioned this pull request May 22, 2024
Merged
@tdrwenski tdrwenski marked this pull request as ready for review May 23, 2024 20:27
@haileyajohnson haileyajohnson merged commit 750304c into Unidata:main May 23, 2024
9 checks passed
@tdrwenski tdrwenski deleted the mfilezip-fixes branch May 24, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyajohnson haileyajohnson haileyajohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdrwenski @haileyajohnson