Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add properties to stringParam response #78

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Add properties to stringParam response #78

merged 2 commits into from
Jan 24, 2024

Conversation

jernestmyers
Copy link
Contributor

Resolves #77

@jernestmyers jernestmyers requested a review from dmfalke January 24, 2024 18:24
@dmfalke
Copy link
Member

dmfalke commented Jan 24, 2024

We also need isNumber to be added to the JSON for StringParam. You may need to add IS_NUMBER to JsonKeys.java.

dmfalke
dmfalke requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@dmfalke dmfalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add isNumber to JSON.

@dmfalke dmfalke mentioned this pull request Jan 24, 2024
Merged
@jernestmyers jernestmyers changed the title Add isMultiLine property to stringParam response Add properties to stringParam response Jan 24, 2024
@jernestmyers jernestmyers requested a review from dmfalke January 24, 2024 21:38
@jernestmyers jernestmyers merged commit 8d29e95 into master Jan 24, 2024
1 check passed
@jernestmyers jernestmyers deleted the add-isMultiLine-to-stringParam-response branch January 24, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmfalke dmfalke dmfalke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StringParamFormatter - Add additional properties
2 participants
@jernestmyers @dmfalke