Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genomics: Finalize menu code for maps #477

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Genomics: Finalize menu code for maps #477

merged 5 commits into from
Oct 18, 2023

Conversation

dmfalke
Copy link
Member

@dmfalke dmfalke commented Sep 6, 2023 •
edited
Loading

This PR uses the new WDK question MapStudiesForToolbar to populate the site header.

Some details:

  • If the question is not defined in the model, the menu item(s) for the eda-based map are not included
  • If the question returns more than one row, then a submenu will be included.
  • If the question returns only one row, then a top-level link will be included.

@dmfalke dmfalke marked this pull request as draft September 6, 2023 20:31
@dmfalke dmfalke changed the title WIP: Genomics: Finalize menu code for maps Genomics: Finalize menu code for maps Sep 19, 2023
@dmfalke dmfalke marked this pull request as ready for review September 19, 2023 14:08
jernestmyers
jernestmyers approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@jernestmyers jernestmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmfalke dmfalke merged commit 339b0d1 into main Oct 18, 2023
1 check passed
@dmfalke dmfalke deleted the fix-map-menu--studyAccessApi branch October 18, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jernestmyers jernestmyers jernestmyers approved these changes

Assignees

@bobular bobular

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmfalke @jernestmyers @bobular