Add condition to deleting marker floaters logic #504
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #427
Previously, deleting a floater always invoked
setActiveVisualizationId(undefined)
. Now, we'll only do so if the viz being deleted is the active viz.NOTE
The deletion will update
analysisState
, causing the loader to spin on the active viz. This may be another thing to consider when we have our deep think about our data requests. As a user, I'd be a bit confused why deleting a non-active viz results in a loading state. This issue feels a bit out of scope for this ticket, but perhaps it's not? Thoughts on if I should investigate further in the context of this ticket, or should it wait until our proper deep think?