Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bipartite network component #517

Merged
merged 11 commits into from
Sep 26, 2023
Merged

Add bipartite network component #517

merged 11 commits into from
Sep 26, 2023

Conversation

asizemore
Copy link
Member

@asizemore asizemore commented Sep 22, 2023

Resolves the first task of #512

To Dos:

  • Add high/low colors to addOns.ts
  • Add column names
  • Clean up how columns are positioned
  • Add default values
  • document
  • figure out who (viz, component, backend) decides color.

Current progress:
Screen Shot 2023-09-22 at 3 58 04 PM

Additional notes:

  • the visualization or frontend correlation app plugin will need to set the link colors because that's not a bipartite network-specific decision.
  • the bipartite network component handles the positioning of the nodes so that when we add a click-to-reposition feature in the future, the frontend can do the whole thing.

Left for later:

  • handling long node names. Should be just a max with and we see "blah..." and on hover see the whole name"
  • Overriding defaults for plot layout. I expect we'll need to do this a bit down the line but we can wait and see what we'll really need

@asizemore asizemore marked this pull request as ready for review September 25, 2023 10:22
Copy link
Contributor

@jernestmyers jernestmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

I made a couple nit-ish suggestions you may or may not wish to consider.

style={{ ...containerStyles, position: 'relative' }}
>
<svg
width={400}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a magic number. Should it be defined by an optional prop with a default value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes definitely!

@asizemore asizemore merged commit 117371c into main Sep 26, 2023
1 check passed
@asizemore asizemore deleted the bipartite-network-component branch September 26, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants