Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added correlation plugin #522

Merged
merged 9 commits into from
Oct 2, 2023
Merged

added correlation plugin #522

merged 9 commits into from
Oct 2, 2023

Conversation

asizemore
Copy link
Member

@asizemore asizemore commented Sep 25, 2023

Resolves tasks in #512

This PR:

  • adds the Correlation compute plugin
  • adds the bipartite network viz
  • uses fake data to generate a bipartite network when the viz is visited
  • adds a working thumbnail

Using the add-correlation of the data service and the rest of the services on their QA images, we can get the following:

Screen.Recording.2023-09-28.at.2.17.17.PM.mov

Turns out that though it's not so hard to generate fake data, it is a little more involved to sub in the requests and compute job status and such so that we can make the app appear and think that the Step 3 should be enabled. So I did a bit on the backend to help us at least just see the app (see add-correlation branch in the data service) but stopped there since we can still see the network enough to verify that it works!

If you do test with the local backend, do not try actually selecting the data in Step 1. The app will try to make a request to the backend but that part of the backend isn't set up yet. In the video, i demo that one can use the drop down, but i don't actually select anything.

Base automatically changed from bipartite-network-component to main September 26, 2023 11:08
@asizemore asizemore marked this pull request as ready for review September 28, 2023 18:55
Copy link
Contributor

@jernestmyers jernestmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only played with the updated stories, but between the code and the screencast, things are looking good! 💪

@asizemore asizemore merged commit 7ab5540 into main Oct 2, 2023
1 check passed
@asizemore asizemore deleted the add-correlation-plugin branch October 2, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants