Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collapsible section to studies menu #600

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Add collapsible section to studies menu #600

merged 5 commits into from
Nov 10, 2023

Conversation

jernestmyers
Copy link
Contributor

@jernestmyers jernestmyers commented Nov 6, 2023 •
edited
Loading

Resolves #553

NOTE: This has not been added to mbio's menu. Awaiting review before doing so.

UPDATE: This has now been added to mbio's menu as well.

Screen.Recording.2023-11-06.at.3.51.49.PM.mov

@jernestmyers jernestmyers requested a review from dmfalke November 6, 2023 20:55
dmfalke
dmfalke reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@dmfalke dmfalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Implementation looks great. There is a voice in my head saying that we should use a native <details> element... you know, leverage the platform and all. Thoughts?

@jernestmyers
Copy link
Contributor Author

This looks great. Implementation looks great. There is a voice in my head saying that we should use a native <details> element... you know, leverage the platform and all. Thoughts?

I ran into issues with styling <details> elements in the past, but a quick read on MDN suggests I shouldn't have...

We also have CollapsibleSection in WDKClient, which I opted against due to a prior memory of limitations (without recollection of what limitations)...

@dmfalke
Copy link
Member

dmfalke commented Nov 7, 2023

Fair enough!

@dmfalke dmfalke self-requested a review November 10, 2023 15:21
@dmfalke
Copy link
Member

dmfalke commented Nov 10, 2023

This looks great, but I think curated studies should default to open. I suspect clinepi outreach would prefer that.

dmfalke
dmfalke approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@dmfalke dmfalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jernestmyers jernestmyers merged commit 139dc2e into main Nov 10, 2023
1 check passed
@jernestmyers jernestmyers deleted the collapsible-section-study-menu branch November 10, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmfalke dmfalke dmfalke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EDA studies menu: ability to collapse UDs, or show them below?
2 participants
@jernestmyers @dmfalke