Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render provider label only when meaningful #633

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Render provider label only when meaningful #633

merged 2 commits into from
Nov 13, 2023

Conversation

jernestmyers
Copy link
Contributor

Resolves #613

I added "TEMP" in the code comment because I feel it's more appropriate to send null or undefined from the model if/when we wish not to render label info.

@jernestmyers jernestmyers merged commit 67bdcc8 into main Nov 13, 2023
1 check passed
@jernestmyers jernestmyers deleted the prevent-meaningless-var-render branch November 13, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurreco-uga aurreco-uga aurreco-uga approved these changes

Assignees

@dmfalke dmfalke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EDA variable view: remove clutter: if the variable does not have a provider laber, do not show it.
3 participants
@jernestmyers @aurreco-uga @dmfalke