Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render transcript filter in SRT for genes only #647

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

jernestmyers
Copy link
Contributor

Resolves #523 (comment)

NOTE: Pulling the data to check if it's a transcript feels brittle. Is there a more robust way?

@jernestmyers jernestmyers requested a review from dmfalke November 15, 2023 21:30
@dmfalke
Copy link
Member

dmfalke commented Nov 15, 2023

NOTE: Pulling the data to check if it's a transcript feels brittle. Is there a more robust way?

I thought the record class object included the available view filters, but I'm not seeing that information. So, this might be the only reliable way.

Copy link
Member

@dmfalke dmfalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. See my suggestion.

@jernestmyers jernestmyers force-pushed the srt-filter-removal-request branch from b6b2404 to 19efa87 Compare November 16, 2023 15:23
@jernestmyers jernestmyers requested a review from dmfalke November 16, 2023 15:23
@jernestmyers jernestmyers merged commit 98815d6 into main Nov 16, 2023
1 check passed
@jernestmyers jernestmyers deleted the srt-filter-removal-request branch November 16, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants