[WCM] Using api.web3modal.com #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeknovis
force-pushed
the
feat/wcm-api-update
branch
from
a7a8529 to
6ce5888
Compare
flypaper0
reviewed
Jan 8, 2024
| @@ -52,6 +53,16 @@ final class SignPresenter: ObservableObject { | |||
| Web3Modal.present(from: nil) | |||
| } | |||
|
|
|||
| func connectWalletWithWCM() { | |||
| Task { | |||
| WalletConnectModal.set(sessionParams: .init( | |||
There was a problem hiding this comment.
I do not see async context here, do you need Task?
flypaper0
reviewed
Jan 8, 2024
| deeplinkHandler: WalletDeeplinkHandler | ||
| ) { | ||
| self.wallet = wallet | ||
| self.deeplinkHandler = deeplinkHandler | ||
| preferredPlatform = wallet.app.ios != nil ? .native : .browser | ||
| preferredPlatform = wallet.appStore != nil ? .native : .browser | ||
| } | ||
|
|
||
| func handle(_ event: Event) { | ||
| switch event { | ||
| case .onAppear: |
There was a problem hiding this comment.
case .onAppear, .didTapUniversalLink, . didTapTryAgain:
flypaper0
reviewed
Jan 8, 2024
| // iOS 14 doesn't have extra separators below the list by default. | ||
| } else { | ||
| // To remove only extra separators below the list: | ||
| UITableView.appearance().tableFooterView = UIView() |
There was a problem hiding this comment.
Can it affect client's app?
flypaper0
reviewed
Jan 8, 2024
| } | ||
|
|
||
| // To remove all separators including the actual ones: | ||
| UITableView.appearance().separatorStyle = .none |
radeknovis
force-pushed
the
feat/wcm-api-update
branch
from
6ce5888 to
6bbb9f4
Compare
radeknovis
force-pushed
the
feat/wcm-api-update
branch
from
2eb69cd to
cbd25b3
Compare
radeknovis
force-pushed
the
feat/wcm-api-update
branch
from
cbd25b3 to
ff313dd
Compare
radeknovis
force-pushed
the
feat/wcm-api-update
branch
from
ff313dd to
33a036f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces explorer api with api.web3modal.com. Also includes change to paginate response