Add support for test config overrides #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoraaver
force-pushed
the
config-override
branch
2 times, most recently
from
6409602
to
c448f53
Compare
loganek
reviewed
Feb 29, 2024
It can be useful to override the config for certain tests. The main use case for this is to override environment variables which control test assertions (e.g. NO_DANGLING_FILESYSTEM, ERRNO_MODE_WINDOWS). When running the tests in CI, it would be nicer to support this without manually modifying the JSON test config files.
zoraaver
force-pushed
the
config-override
branch
from
c448f53
to
3b26de8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful to override the config for certain tests. The main use case for this is to override environment variables which control test assertions (e.g.
NO_DANGLING_FILESYSTEM,ERRNO_MODE_WINDOWS). When running the tests in CI, it would be nicer to support this without manually modifying the JSON test config files.Any feedback would be appreciated, thanks.