Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct elife for cs2_wo_timecorr #1260

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Correct elife for cs2_wo_timecorr #1260

merged 1 commit into from
Sep 7, 2023

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Sep 7, 2023

What does the code in this PR do / what does it improve?

In #1258, the elife correction of cs2_wo_timecorr in corrected_areas was removed. To be aligned with PeakCorrectedAreas

class PeakCorrectedAreas(CorrectedAreas):
, we should correct the elife also for cs2_wo_timecorr.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

From https://straxen--1260.org.readthedocs.build/en/1260/reference/datastructure_nT.html#corrected-areas:
image

Comparison between old and new results of run 051806, blinded events removed:

----------
old nan cs2 23.2%
new nan cs2 23.2%
difference cs2 0.0%
mean abs difference cs2 0.0e+00
----------
old nan cs2_area_fraction_top 0.0%
new nan cs2_area_fraction_top 0.0%
difference cs2_area_fraction_top 0.0%
mean abs difference cs2_area_fraction_top 0.0e+00
----------
old nan cs2_area_fraction_top_wo_elifecorr 0.0%
new nan cs2_area_fraction_top_wo_elifecorr 0.0%
difference cs2_area_fraction_top_wo_elifecorr 0.0%
mean abs difference cs2_area_fraction_top_wo_elifecorr 0.0e+00
----------
old nan cs2_area_fraction_top_wo_picorr 0.0%
new nan cs2_area_fraction_top_wo_picorr 0.0%
difference cs2_area_fraction_top_wo_picorr 0.0%
mean abs difference cs2_area_fraction_top_wo_picorr 0.0e+00
----------
old nan cs2_area_fraction_top_wo_timecorr 0.0%
new nan cs2_area_fraction_top_wo_timecorr 0.0%
difference cs2_area_fraction_top_wo_timecorr 27.9%
mean abs difference cs2_area_fraction_top_wo_timecorr 1.6e-08
----------
old nan cs2_wo_elifecorr 0.0%
new nan cs2_wo_elifecorr 0.0%
difference cs2_wo_elifecorr 0.0%
mean abs difference cs2_wo_elifecorr 0.0e+00
----------
old nan cs2_wo_picorr 0.0%
new nan cs2_wo_picorr 0.0%
difference cs2_wo_picorr 0.0%
mean abs difference cs2_wo_picorr 0.0e+00
----------
old nan cs2_wo_timecorr 0.0%
new nan cs2_wo_timecorr 23.2%
difference cs2_wo_timecorr 100.0%
mean abs difference cs2_wo_timecorr 4.9e+03
----------
old nan endtime 0.0%
new nan endtime 0.0%
difference endtime 0.0%
mean abs difference endtime 0.0e+00
----------
old nan time 0.0%
new nan time 0.0%
difference time 0.0%
mean abs difference time 0.0e+00
----------

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

@dachengx dachengx marked this pull request as ready for review September 7, 2023 20:07
@dachengx dachengx requested a review from jingqiangye September 7, 2023 20:07
@dachengx dachengx merged commit a1eadc4 into master Sep 7, 2023
8 checks passed
@dachengx dachengx deleted the add_back_elife branch September 7, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants