Changes to support new array-based sitewire-net changes #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lavin <chris.lavin@amd.com>
eddieh-xlnx
reviewed
Nov 21, 2024
test/src/com/xilinx/rapidwright/design/compare/TestDesignComparator.java
Show resolved
Hide resolved
eddieh-xlnx
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update tests to reflect bug fixes and minor behavior changes associated with a new storage method in
SiteInstobjects where instead of using maps, theNetto site wire now uses an array. This led to a change in iteration order and also a bug was discovered whenSiteInstare renamed, they were not getting updated in theSet<SiteInst>class members ofNetobjects. This led to some failures to fully remove the references when prompted in some of the tests.