Feat (brevitas_examples/llm): remove dependencies from optimum-amd #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giuseppe5
requested review from
nickfraser
and removed request for
nickfraser
nickfraser
requested changes
Nov 18, 2024
| from .data import get_wikitext2 | ||
|
|
||
|
|
||
| class DatasetToDevice(torch.utils.data.Dataset): |
|
|
||
|
|
||
| @torch.no_grad() | ||
| def recursive_to_device(tensor_or_iterable: Union[Iterable, torch.Tensor], device) -> None: |
|
|
||
|
|
||
| @torch.no_grad() | ||
| def compute_perplexity( |
| @@ -16,6 +16,10 @@ | |||
| limitations under the License. | |||
| """ | |||
There was a problem hiding this comment.
Old licence still necessary? Seems the entire contents of this file have changed...
| data_files={"validation": "en/c4-validation.00000-of-00008.json.gz"}, | ||
| ) | ||
|
|
||
| if fuse_sequences: |
There was a problem hiding this comment.
I think this part as well.
|
Please also remove |
nickfraser
approved these changes
Nov 20, 2024
| accelerate | ||
| datasets | ||
| onnx | ||
| onnx-tools |
There was a problem hiding this comment.
onnx-tools not required?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Remove circular dependencies between brevitas and optimum-amd
Changes Made in this PR
Brevitas now implements all the functions required for the LLM entrypoint.
Testing Summary
Risk Highlight
Checklist
devbranch.