Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (core/quant/float): use eps to avoid log(0) #957

Merged
merged 2 commits into from
May 28, 2024
Merged

Fix (core/quant/float): use eps to avoid log(0) #957

merged 2 commits into from
May 28, 2024

Conversation

Giuseppe5
Copy link
Collaborator

No description provided.

@Giuseppe5 Giuseppe5 requested a review from nickfraser May 23, 2024 13:17
@nickfraser
Copy link
Collaborator

LGTM!

@Giuseppe5 Giuseppe5 merged commit 486a6df into Xilinx:dev May 28, 2024
335 of 347 checks passed
@Giuseppe5 Giuseppe5 deleted the fix_minifloat_grad branch May 28, 2024 07:52
Giuseppe5 added a commit to Giuseppe5/brevitas that referenced this pull request May 31, 2024
@Giuseppe5
Fix (core/quant/float): use eps to avoid log(0) (Xilinx#957)
14e2080
@Giuseppe5 Giuseppe5 mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfraser nickfraser Awaiting requested review from nickfraser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Giuseppe5 @nickfraser