Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (core/quant/float): use eps to avoid log(0) #957

Merged
merged 2 commits into from
May 28, 2024
Merged

Fix (core/quant/float): use eps to avoid log(0) #957

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a9196b
Fix (core/quant/float): use eps to avoid log(0)
Giuseppe5 May 23, 2024
975edaa
Fix for None dtype
Giuseppe5 May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/brevitas/core/quant/float.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,14 @@ def __init__(
self.scaling_impl = scaling_impl
self.float_clamp_impl = float_clamp_impl

# To avoid log(0), we add small a small value based on the used dtype
if dtype is None:
dtype = torch.get_default_dtype()
self.eps = torch.finfo(dtype).tiny

@brevitas.jit.script_method
def internal_scale(self, x):
internal_scale = floor_ste(torch.log2(torch.abs(x))) - self.mantissa_bit_width()
internal_scale = floor_ste(torch.log2(torch.abs(x) + self.eps)) - self.mantissa_bit_width()
internal_scale = torch.clamp_min(internal_scale, self.fp_internal_scale_min())
internal_scale = torch.exp2(internal_scale)
return internal_scale
Expand Down
Loading