Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add volume control #9

Merged
merged 3 commits into from
Feb 4, 2024
Merged

feat: Add volume control #9

merged 3 commits into from
Feb 4, 2024

Commits on Feb 3, 2024

  1. feat: Add volume control

    - In usePlayer hook:
      - Add states to control volume:
        - playerVolume
        - playerMuted
      - Add changePlayerVolume function to handle volume change
      - Add to the return object:
        - playerVolume
        - changePlayerVolume
        - playerMuted
        - setPlayerMuted
    
    - In App component:
      - Create a volume slider
      - Create a mute/unmute button
      - Additionally make formatting changes
    ZaikoXander committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    51828fb View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. test(e2e): Add volumeControl tests

    - Volume change while playing
    - Starting with pre-set volume
    - Starting already muted by changing volume to zero
    - Starting already muted by mute button
    - Muting and unmuting by changing volume while playing
    - Muting and unmuting using mute button while playing
    - Changing volume while it's muted and playing
    - Muting by changing volume to zero and unmuting while playing
    ZaikoXander committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    a04d1e2 View commit details
    Browse the repository at this point in the history
  2. feat: Create VolumeControl component

    - Separate the volume control into a new component
    ZaikoXander committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    67f0e50 View commit details
    Browse the repository at this point in the history