Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F1 Visa Experiences #577

Merged
merged 29 commits into from
Feb 10, 2024
Merged

F1 Visa Experiences #577

merged 29 commits into from
Feb 10, 2024

Conversation

stackaway
Copy link
Contributor

@stackaway stackaway commented Feb 10, 2024

Pull Request for ML-Crate 💡

Issue Title: F1 Visa Experiences

  • Info about the related issue (Aim of the project) : Finding out if the review is positive, negative or neutral.
  • Name: Churnika S Mundas
  • GitHub ID: (https://github.com/stackaway)
  • Idenitfy yourself: JWOC 2024 Contributor

Closes: #128

Describe the add-ons or changes you've made 📃

We analyse the data, preprocess and visualize the features. We then investigated two predictive models. The data was split into two parts, a train set and a test set.

We started with Logistic Regression, Random Forest Classifier and SVM and SVM had the highest accuracy followed by Random Forest Classifier.

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Logistic Regression, Random Forest Classifier and SVM and SVM had the highest accuracy followed by Random Forest Classifier.

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @stackaway :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the template and update the README file to make it eye pleasing. (Suggestion: Add the EDA results under the Visualization tag). Here is the template, https://github.com/abhisheks008/ML-Crate/blob/main/.github/readme_template.md

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Feb 10, 2024
@stackaway
Copy link
Contributor Author

I have updated the README file

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved under JWOC 2024 @stackaway

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 JWOC This issue/pull request will be considered for JWOC 2k22. and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Feb 10, 2024
@abhisheks008 abhisheks008 merged commit 4cdae8a into abhisheks008:main Feb 10, 2024
@abhisheks008
Copy link
Owner

Hi @stackaway can you please share your email ID for further communication.

@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Feb 10, 2024
@abhisheks008
Copy link
Owner

Hi @stackaway can you please share your email ID for further communication.

@stackaway
Copy link
Contributor Author

churnika.mundas@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 JWOC This issue/pull request will be considered for JWOC 2k22. Points Added 🎉 This issue's points has been added to the leaderboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F1 Visa Experiences
2 participants