Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary std::string_view creation #754

Merged
merged 1 commit into from
Oct 7, 2024
Merged

remove unnecessary std::string_view creation #754

merged 1 commit into from
Oct 7, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 7, 2024

Removes unnecessary string_view creation and adds likely and unlikely to several branches.

@anonrig anonrig requested review from lemire and jasnell October 7, 2024 02:38
lemire
lemire approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is all fine.

I would be careful generally with likely and unlikely markers. The compiler might not do what you expect.

In this case, it is unlikely to matter either way.

@anonrig anonrig merged commit ddada9b into main Oct 7, 2024
28 checks passed
@anonrig anonrig deleted the remove-unnecessary-string-view branch October 7, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anonrig @lemire