Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary std::string_view creation #754

Merged
merged 1 commit into from
Oct 7, 2024
Merged

remove unnecessary std::string_view creation #754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ result_type parse_url_impl(std::string_view user_input,

// We refuse to parse URL strings that exceed 4GB. Such strings are almost
// surely the result of a bug or are otherwise a security concern.
if (user_input.size() > std::numeric_limits<uint32_t>::max()) {
if (user_input.size() > std::numeric_limits<uint32_t>::max()) [[unlikely]] {
url.is_valid = false;
}
// Going forward, user_input.size() is in [0,
Expand Down Expand Up @@ -67,20 +67,19 @@ result_type parse_url_impl(std::string_view user_input,
url.reserve(reserve_capacity);
}
std::string tmp_buffer;
std::string_view internal_input;
if (unicode::has_tabs_or_newline(user_input)) {
std::string_view url_data;
if (unicode::has_tabs_or_newline(user_input)) [[unlikely]] {
tmp_buffer = user_input;
// Optimization opportunity: Instead of copying and then pruning, we could
// just directly build the string from user_input.
helpers::remove_ascii_tab_or_newline(tmp_buffer);
internal_input = tmp_buffer;
} else {
internal_input = user_input;
url_data = tmp_buffer;
} else [[likely]] {
url_data = user_input;
}

// Leading and trailing control characters are uncommon and easy to deal with
// (no performance concern).
std::string_view url_data = internal_input;
helpers::trim_c0_whitespace(url_data);

// Optimization opportunity. Most websites do not have fragment.
Expand Down
Loading