Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(breaking-change): update for nodes 18 and 20 #59

Merged
merged 7 commits into from
Dec 5, 2023
Merged

fix(breaking-change): update for nodes 18 and 20 #59

merged 7 commits into from
Dec 5, 2023

Conversation

shazron
Copy link
Member

@shazron shazron commented Nov 14, 2023

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@moritzraho
Copy link
Member

Approved but needs fixing

@shazron shazron mentioned this pull request Nov 23, 2023
Closed
@shazron
Copy link
Member Author

shazron commented Dec 5, 2023

all tests now pass, merging this

@shazron shazron merged commit 87a2e7f into master Dec 5, 2023
5 checks passed
@shazron shazron deleted the update-node-18-20 branch December 5, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moritzraho moritzraho moritzraho approved these changes

@MichaelGoberling MichaelGoberling MichaelGoberling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shazron @moritzraho @MichaelGoberling