Merging changes to release branch for 1.14.1 patch release

appshell/appshell_extension_handler.h

@@ -160,7 +160,7 @@ class AppShellExtensionHandler : public CefV8Handler {
  CefString& exception) {
 
  // The only messages that are handled here is getElapsedMilliseconds(),
- // GetCurrentLanguage(), GetApplicationSupportDirectory(), and GetRemoteDebuggingPort().
+ // GetCurrentLanguage(), and GetApplicationSupportDirectory().
  // All other messages are passed to the browser process.
  if (name == "GetElapsedMilliseconds") {
  retval = CefV8Value::CreateDouble(GetElapsedMilliseconds());
@@ -170,8 +170,6 @@ class AppShellExtensionHandler : public CefV8Handler {
  retval = CefV8Value::CreateString(AppGetSupportDirectory());
  } else if (name == "GetUserDocumentsDirectory") {
  retval = CefV8Value::CreateString(AppGetDocumentsDirectory());
- } else if (name == "GetRemoteDebuggingPort") {
- retval = CefV8Value::CreateInt(REMOTE_DEBUGGING_PORT);
  } else {
  // Pass all messages to the browser process. Look in appshell_extensions.cpp for implementation.
  CefRefPtr<CefBrowser> browser = CefV8Context::GetCurrentContext()->GetBrowser();

appshell/appshell_extensions.cpp

@@ -37,6 +37,7 @@
 #include "update.h"
 
 extern std::vector<CefString> gDroppedFiles;
+extern int g_remote_debugging_port;
 
 namespace appshell_extensions {
 
@@ -842,6 +843,8 @@ class ProcessMessageDelegate : public ClientHandler::ProcessMessageDelegate {
  uberDict->SetList(0, dirContents);
  uberDict->SetList(1, allStats);
  responseArgs->SetList(2, uberDict);
+ } else if (message_name == "GetRemoteDebuggingPort") {
+ responseArgs->SetInt(2, g_remote_debugging_port);
  }
 
  else {

appshell/appshell_extensions.js

@@ -640,8 +640,8 @@ if (!brackets) {
  * @return int. The remote debugging port used by the appshell.
  */
  native function GetRemoteDebuggingPort();
- appshell.app.getRemoteDebuggingPort = function () {
- return GetRemoteDebuggingPort();
+ appshell.app.getRemoteDebuggingPort = function (callback) {
+ GetRemoteDebuggingPort(callback || _dummyCallback);
  };
 
 

appshell/cefclient.cpp

@@ -7,6 +7,7 @@
 #include <cstdlib>
 #include <sstream>
 #include <string>
+#include <errno.h>
 #include "include/cef_app.h"
 #include "include/cef_browser.h"
 #include "include/cef_command_line.h"
@@ -19,6 +20,7 @@
 #include "config.h"
 
 CefRefPtr<ClientHandler> g_handler;
+int g_remote_debugging_port = 0;
 
 #ifdef OS_WIN
 bool g_force_enable_acc = false;
@@ -95,7 +97,28 @@ void AppGetSettings(CefSettings& settings, CefRefPtr<CefCommandLine> command_lin
  command_line->GetSwitchValue(client::switches::kJavascriptFlags);
 
  // Enable dev tools
- settings.remote_debugging_port = REMOTE_DEBUGGING_PORT;
+ CefString debugger_port = command_line->GetSwitchValue("remote-debugging-port");
+ if (!debugger_port.empty()) {
+ const long port = strtol(debugger_port.ToString().c_str(), NULL, 10);
+ if (errno == ERANGE || port == 0) {
+ LOG(ERROR) << "Could not enable remote debugging."
+ << " Error while parsing remote-debugging-port arg: "<< debugger_port.ToString();
+ errno = 0;
+ }
+ else {
+ static const long max_port_num = 65534;
+ static const long max_reserved_port_num = 1025;
+ if (port >= max_reserved_port_num && port <= max_port_num) {
+ g_remote_debugging_port = static_cast<int>(port);
+ settings.remote_debugging_port = g_remote_debugging_port;
+ }
+ else {
+ LOG(ERROR) << "Cannot enable remote debugging on port "<< port
+ << ". Port numbers should be between "<< max_reserved_port_num
+ << " and " << max_port_num << ".";
+ }
+ }
+ }
 
  std::wstring versionStr = appshell::AppGetProductVersionString();
 

appshell/config.h

@@ -82,8 +82,6 @@
 
 #endif
 
-#define REMOTE_DEBUGGING_PORT 9234
-
 // Comment out this line to enable OS themed drawing
 #define DARK_UI 
 #define DARK_AERO_GLASS