Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maven dependency #591

Merged
merged 6 commits into from
Aug 23, 2024

Conversation

jasonkatonica
Copy link
Contributor

This update adds maven as a dependency to build and test the OpenJCEPlus project. As part of this effort other dependencies that were used in the past for this project have been removed.

Signed-off-by: Jason Katonica katonica@us.ibm.com

This update adds maven as a dependency to build and test the OpenJCEPlus
project. As part of this effort other dependencies that were used in
the past for this project have been removed.

Signed-off-by: Jason Katonica <katonica@us.ibm.com>
@jasonkatonica
Copy link
Contributor Author

This update is dependent upon adoptium/aqa-tests#5479

scripts/getDependencies.pl Show resolved Hide resolved
@llxia
Copy link
Contributor

llxia commented Aug 22, 2024

Checksum is skipped.

downloading https://dlcdn.apache.org/maven/maven-3/3.9.8/binaries/apache-maven-3.9.8-bin.tar.gz
--> file downloaded to ./apache-maven-bin.tar.gz
Checksum verification skipped for ./apache-maven-bin.tar.gz

Internal job

sha512 is wrong as there is no logic checking for sha512.

sha512 => '7d171def9b85846bf757a2cec94b7529371068a0670df14682447224e57983528e97a6d1b850327e4ca02b139abaab7fcb93c4315119e6f0ffb3f0cbc0d0b9a2'

I think we should do something similar to

shaurl => 'https://ci.adoptium.net/view/Dependencies/job/dependency_pipeline/lastSuccessfulBuild/artifact/asmtools/asmtools-core-7.0.b10-ea.jar.sha256sum.txt',
shafn => 'asmtools.jar.sha256sum.txt',
shaalg => '256'

change shaalg => '256' to shaalg => '512'

@jasonkatonica jasonkatonica marked this pull request as ready for review August 23, 2024 11:09
@jasonkatonica
Copy link
Contributor Author

Hi @llxia I attempted via commits d07ba46 and 6867f76 and a00e9f8 to directly use the SHA512 hash file published on the website ran into issues with it recognizing either the hash value or the value of the file itself. My guess is that the URL does not end in .txt and is using 512 making it different ? In the end I simply placed the sha1 hash of the file into script for validation which seems to work now when I run it:

07:52:47       [exec] --------------------------------------------
07:52:47       [exec] Starting download third party dependent jars
07:52:47       [exec] --------------------------------------------
07:52:47       [exec] downloading dependent third party jars to C:/Users/jenkins/testDependency/lib
07:52:47       [exec] downloading https://dlcdn.apache.org/maven/maven-3/3.9.8/binaries/apache-maven-3.9.8-bin.tar.gz
07:52:47       [exec] --> file downloaded to C:/Users/jenkins/testDependency/lib/apache-maven-bin.tar.gz
07:52:47       [exec] downloaded dependent third party jars successfully

@jasonkatonica jasonkatonica marked this pull request as draft August 23, 2024 12:03
@llxia
Copy link
Contributor

llxia commented Aug 23, 2024

Thanks for making it work.

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonkatonica jasonkatonica marked this pull request as ready for review August 23, 2024 16:40
@llxia llxia merged commit d736fc8 into adoptium:master Aug 23, 2024
3 checks passed
@llxia
Copy link
Contributor

llxia commented Aug 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants