Make use of mvn for OpenJCEPlus test execution #5479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This update is dependent upon adoptium/TKG#591 |
|
Did we test this on Windows? If so, could you provide the Grinder link? Thanks |
This update allows for the test infrastructure to make use of `mvn` directly for testing `OpenJCEPlus`. This allows for `mvn` to control dependency usage along with using the same test infrastructure and plugins in use within the open source project. Signed-off-by: Jason Katonica <katonica@us.ibm.com>
jasonkatonica
force-pushed
the
katonica/feature/junit5executionopenjceplus
branch
from
eee565a
to
929b0e4
Compare
|
Hi @llxia I did need to make an update using 929b0e4 to get this to work on windows. The code now uses fully qualified paths to mvn and to the pom.xml file in order to work. Setting the path to mvn on windows had some issues. I ran this on the various platforms using the following grinder jobs with this new code:
|
LongyuZhang
approved these changes
Aug 23, 2024
jasonkatonica
added a commit
to jasonkatonica/aqa-tests
that referenced
this pull request
Aug 23, 2024
* Make use of mvn for OpenJCEPlus test execution This update allows for the test infrastructure to make use of `mvn` directly for testing `OpenJCEPlus`. This allows for `mvn` to control dependency usage along with using the same test infrastructure and plugins in use within the open source project. Signed-off-by: Jason Katonica <katonica@us.ibm.com> * Use fully qualified names instead of PATH --------- Signed-off-by: Jason Katonica <katonica@us.ibm.com>
jasonkatonica
added a commit
to jasonkatonica/aqa-tests
that referenced
this pull request
Aug 23, 2024
* Make use of mvn for OpenJCEPlus test execution This update allows for the test infrastructure to make use of `mvn` directly for testing `OpenJCEPlus`. This allows for `mvn` to control dependency usage along with using the same test infrastructure and plugins in use within the open source project. Signed-off-by: Jason Katonica <katonica@us.ibm.com> * Use fully qualified names instead of PATH --------- Signed-off-by: Jason Katonica <katonica@us.ibm.com>
jasonkatonica
added a commit
to jasonkatonica/aqa-tests
that referenced
this pull request
Aug 23, 2024
* Make use of mvn for OpenJCEPlus test execution This update allows for the test infrastructure to make use of `mvn` directly for testing `OpenJCEPlus`. This allows for `mvn` to control dependency usage along with using the same test infrastructure and plugins in use within the open source project. Signed-off-by: Jason Katonica <katonica@us.ibm.com> * Use fully qualified names instead of PATH --------- Signed-off-by: Jason Katonica <katonica@us.ibm.com>
jasonkatonica
added a commit
to jasonkatonica/aqa-tests
that referenced
this pull request
Aug 23, 2024
* Make use of mvn for OpenJCEPlus test execution This update allows for the test infrastructure to make use of `mvn` directly for testing `OpenJCEPlus`. This allows for `mvn` to control dependency usage along with using the same test infrastructure and plugins in use within the open source project. Signed-off-by: Jason Katonica <katonica@us.ibm.com> * Use fully qualified names instead of PATH --------- Signed-off-by: Jason Katonica <katonica@us.ibm.com>
This was referenced Aug 23, 2024
llxia
pushed a commit
that referenced
this pull request
Aug 23, 2024
* Make use of mvn for OpenJCEPlus test execution This update allows for the test infrastructure to make use of `mvn` directly for testing `OpenJCEPlus`. This allows for `mvn` to control dependency usage along with using the same test infrastructure and plugins in use within the open source project. * Use fully qualified names instead of PATH --------- Signed-off-by: Jason Katonica <katonica@us.ibm.com>
llxia
pushed a commit
that referenced
this pull request
Aug 23, 2024
* Make use of mvn for OpenJCEPlus test execution This update allows for the test infrastructure to make use of `mvn` directly for testing `OpenJCEPlus`. This allows for `mvn` to control dependency usage along with using the same test infrastructure and plugins in use within the open source project. * Use fully qualified names instead of PATH --------- Signed-off-by: Jason Katonica <katonica@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows for the test infrastructure to make use of
mvndirectly for testingOpenJCEPlus. This allows formvnto control dependency usage along with using the same test infrastructure and plugins in use within the open source project.Signed-off-by: Jason Katonica katonica@us.ibm.com