Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issues-2740] fix url of jmc 9 links #2742

Merged

Conversation

xavierfacq
Copy link
Member

@xavierfacq xavierfacq commented Mar 27, 2024

Description of change

Fix links
reported in issue #2740

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 5ac49e9
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/660417ce66d3080008029a00
😎 Deploy Preview https://deploy-preview-2742--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.24%. Comparing base (2218887) to head (5ac49e9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2742   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          88       88           
  Lines        6759     6759           
  Branches      584      584           
=======================================
  Hits         6708     6708           
  Misses         51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiekang
Copy link
Contributor

jiekang commented Mar 27, 2024

Hi @xavierfacq! Just FYI, you can have GitHub automatically link a PR and issue using keywords in the PR description, or commit (preferably PR description for me):

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

E.g. if your PR description had the phrase:

Fixes #2740

@xavierfacq
Copy link
Member Author

Yes, I forgot to add it in the description.
You have opened a new issue, is the same problem or a new one ? About links of the jmc ?

@gdams gdams merged commit f4f44a1 into adoptium:main Mar 28, 2024
12 checks passed
gdams added a commit that referenced this pull request Apr 3, 2024
gdams added a commit that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants