Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch constants from api instead of having values hardcoded #2787

Merged
merged 11 commits into from
Apr 30, 2024

Conversation

xavierfacq
Copy link
Member

@xavierfacq xavierfacq commented Apr 16, 2024

Description of change

This is a suggestion, we have added some new endpoints in the API, and I suggest to use it in the website.

  • get OS from API
  • get Architectures from the API

Let me know!

Checklist

  • npm test passes

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit d556755
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/663063b1591d3e000865408a
😎 Deploy Preview https://deploy-preview-2787--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xavierfacq xavierfacq marked this pull request as ready for review April 29, 2024 21:06
@karianna karianna requested a review from gdams April 30, 2024 03:21
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.25%. Comparing base (305e6dd) to head (d556755).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2787   +/-   ##
=======================================
  Coverage   99.24%   99.25%           
=======================================
  Files          88       89    +1     
  Lines        6773     6851   +78     
  Branches      587      602   +15     
=======================================
+ Hits         6722     6800   +78     
  Misses         51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xavierfacq xavierfacq merged commit b69b24b into adoptium:main Apr 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants