-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixPB: Install capstone 4 from repositories or source #3119
Conversation
Moving back to draft until I put the changes in to restrict build by architecture to reduce library size. Also awaiting on merge of #3120 which is preventing the VPC checks from passing. |
Updated to only build one platform for each build to reduce library size. Rebasing on top of maven signature PR which has now been merged: https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1692/ |
Need to consider whether using the default compiler on each machine is sensible given that this is a library which will be reshipped... |
93e2879
to
f3ed08f
Compare
Latest VPC run (linked in the description) looks like it has run through without problems related to this PR. |
Converting back to draft due to consideration of having a pre-built versions stored on our servers that is downloaded during the build process in order to ensure reproducibility. |
Testing along with the corresponding build script changes in VPC 1729 |
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Re-running with the updates + rebase of the infrastructure PR, and updates to the build PR to move all the selection logic into |
Noting that this is not in the DockerStatic role but since there are no tests requiring this yet that is not a requirement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Slightly concerned by the test case failures showing here, but that was are using the main development branch of JDK22 so i don't think it's related ... running https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1731 with JDK21. |
Looks like it was due to a bunch of hung processes causing the failures (Except the ones that were showing a yellow warning status which were due to the MBCS tests failing - suspect we'll need to look at that separately since the test may no longer be valid for JDK21+ ... New run after clearing processes ir running better: https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1732/ |
1732 mostly worked other than Solaris 10 which had an issue downloading the Liberica JDK11. |
Checklist
This is the machine setup part of #hsdis