-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hsdis support into the build for JDK20+ #3414
base: master
Are you sure you want to change the base?
Conversation
I'm torn about this PR. I really don't like having the --with-capstone in the |
Now leaning towards only having it in a |
As a first pass this has been modified to put it all in |
We should probably add a smoke test for this, but it can be done in a future PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Playbook changes merged and docker images rebuild successfully so this is ready to go subject to approvals. |
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
(Last force push was for a rebase) |
Knocking back to draft following this week's PMC meeting where a decision was made not to include this yet pending further understanding of whether it is really useful for a normal build. |
Partial implementation of adoptium/adoptium#213 - limited to Linux only.