Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hsdis support into the build for JDK20+ #3414

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sxa
Copy link
Member

@sxa sxa commented Jun 30, 2023

Partial implementation of adoptium/adoptium#213 - limited to Linux only.

@sxa sxa self-assigned this Jun 30, 2023
@github-actions github-actions bot added the macos Issues that affect or relate to the MAC OS label Jun 30, 2023
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Jul 6, 2023
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Jul 6, 2023
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Jul 6, 2023
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Jul 6, 2023
@sxa
Copy link
Member Author

sxa commented Oct 5, 2023

I'm torn about this PR. I really don't like having the --with-capstone in the build.sh since it's a location that's specific to where we are installing it on our machines from the playbooks (So ideally the logic should all be in linux.sh). 🤔

@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Oct 5, 2023
@sxa
Copy link
Member Author

sxa commented Oct 5, 2023

I really don't like having the --with-capstone in the build.sh

Now leaning towards only having it in a if variant=temurin block, although realistically it should probably be a parameter to makejdk-any-platform.sh ...

@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Oct 5, 2023
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Oct 5, 2023
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Oct 5, 2023
@sxa
Copy link
Member Author

sxa commented Oct 5, 2023

As a first pass this has been modified to put it all in linux.sh and gate it on Temurin and Linux/aaarch64 or Linux/x64 for JDK20+

@sxa
Copy link
Member Author

sxa commented Oct 5, 2023

We should probably add a smoke test for this, but it can be done in a future PR.

@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Oct 5, 2023
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Oct 6, 2023
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sxa sxa marked this pull request as ready for review October 10, 2023 10:40
@sxa
Copy link
Member Author

sxa commented Oct 10, 2023

Playbook changes merged and docker images rebuild successfully so this is ready to go subject to approvals.

Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa
Copy link
Member Author

sxa commented Oct 10, 2023

(Last force push was for a rebase)

@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Oct 10, 2023
@sxa sxa marked this pull request as draft October 12, 2023 09:32
@sxa
Copy link
Member Author

sxa commented Oct 12, 2023

Knocking back to draft following this week's PMC meeting where a decision was made not to include this yet pending further understanding of whether it is really useful for a normal build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macos Issues that affect or relate to the MAC OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants