change distribution_release to 15.6

[AswathySK]

Need to change the distribution release version from 15.5 to 15.6 in the common role to add the devel-tools repo.

Can we make a change to make this dynamic?
Instead of using the hardcoded version , cant we make it dynamic?
For example instead of 15.5 cant we make it {{ ansible_distribution_major_version }}.{{ ansible_distribution_release }}

Checklist

• commit message has one of the standard prefixes
• faq.md updated if appropriate
• other documentation is changed or added (if applicable)
• playbook changes run through VPC or QPC (if you have access)
• VPC/QPC not applicable for this PR
• for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

[karianna]

@AswathySK You'll need to sign the Eclipse CLA. Vagrant failure is unrelated

[AswathySK]

@karianna ,
Why cant we make it dynamic using {{ ansible_distribution_release }} instead?

[karianna]

Question for @sxa

[sxa]

@karianna , Why cant we make it dynamic using {{ ansible_distribution_release }} instead?

What do you think @Haroon-Khel - looks like you changed the URL path from SLE_15_SP3 to the current format in https://github.com/adoptium/infrastructure/pull/3060/files - if we can use an automatically set distribution version variable instead that sounds reasonable to me.
(Also tagging @steelhead31 since he's looked at some SLES stuff too)

[Haroon-Khel]

I dont have a problem with it being dynamic, saves us having to keep changing the hardcoded variable

[Haroon-Khel]

This pr is fine to merge as it is btw

[sxa]

@Haroon-Khel Noting also that we have a 15.4 reference in

infrastructure/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/DockerStatic/Dockerfiles/Dockerfile.sles15

Line 6 in 822366e

RUN zypper addrepo https://download.opensuse.org/distribution/leap/15.4/repo/oss/ "Main Repository" && zypper --gpg-auto-import-keys refresh

[AswathySK]

@sxa @karianna and @Haroon-Khel Can you please take a look at this issue as well: #3799

[AswathySK]

There is one more issue @karianna , @Haroon-Khel , @sxa ,

While trying to add the Devel-Tools repo with the https://download.opensuse.org/repositories/devel:/tools/15.6/devel:tools.repo url facing the following error.

fatal: [rtj-sles15s390x-svl-test-lij45-1.fyre.ibm.com]: FAILED! => {"changed": false, "cmd": "/usr/bin/zypper --quiet --non-interactive --gpg-auto-import-keys refresh --force -r https://download.opensuse.org/repositories/devel:/tools/15.6/devel:tools.repo", "msg": "Repository 'https://download.opensuse.org/repositories/devel:/tools/15.6/devel:tools.repo' not found by its alias, number, or URI.\nSome of the repositories have not been refreshed because they were not known.", "rc": 3, "stderr": "Repository 'https://download.opensuse.org/repositories/devel:/tools/15.6/devel:tools.repo' not found by its alias, number, or URI.\nSome of the repositories have not been refreshed because they were not known.\n", "stderr_lines": ["Repository 'https://download.opensuse.org/repositories/devel:/tools/15.6/devel:tools.repo' not found by its alias, number, or URI.", "Some of the repositories have not been refreshed because they were not known."], "stdout": "", "stdout_lines": []}

As a fix tried adding the autorefresh parameter to the zypper_repository module as well tried to do a zypper refresh for the machine , both these fixes were not helpful.Even from cmd it was not working succesfully:

/usr/bin/zypper --quiet --non-interactive --gpg-auto-import-keys refresh --force -r https://download.opensuse.org/repositories/devel:/tools/15.6/devel:tools.repo
Repository 'https://download.opensuse.org/repositories/devel:/tools/15.6/devel:tools.repo' not found by its alias, number, or URI.
Some of the repositories have not been refreshed because they were not known.

Succesful execution of this task was able to be achieved by making the following change:

- name: Add Devel-Tools repository (SLES15)
  zypper_repository:
    repo: https://download.opensuse.org/repositories/devel:/tools/15.6/
    auto_import_keys: yes
    state: present
  when:
    - ansible_distribution_major_version == "15"
  tags: patch_update

[karianna]

Pedantry, would it make more sense to make ansible_distribution_release the entire 15.6? Later on it might move to 16.x....

[AswathySK]

@karianna , I did not change it because the when condition checks whether it is sles 15 or not.
We can either make it {{ ansible_distribution_major_version }}.{{ ansible_distribution_release }} or remove the when condition :

  when:
    - ansible_distribution_major_version == "15"