Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change distribution_release to 15.6 #3798

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −1
Open

change distribution_release to 15.6 #3798

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ff508e
change distribution_release to 15.6
AswathySK Nov 5, 2024
88c3d8d
Merge branch 'adoptium:master' into devel-tools-correction
AswathySK Nov 13, 2024
c3eb2cf
Make distribution release dynamic
AswathySK Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Common/tasks/SLES.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@

- name: Add Devel-Tools repository (SLES15)
zypper_repository:
repo: https://download.opensuse.org/repositories/devel:/tools/15.5/devel:tools.repo
name: devel-tools
repo: 'https://download.opensuse.org/repositories/devel:/tools/15.{{ ansible_distribution_release }}/'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantry, would it make more sense to make ansible_distribution_release the entire 15.6? Later on it might move to 16.x....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karianna , I did not change it because the when condition checks whether it is sles 15 or not.
We can either make it {{ ansible_distribution_major_version }}.{{ ansible_distribution_release }} or remove the when condition :

  when:
    - ansible_distribution_major_version == "15"

auto_import_keys: yes
state: present
when:
Expand Down
Loading