Support for Loongson jdk build

[Panxuefeng-loongson]

Hi,

I'm a member of the openjdk development team from Loongson. We intend to distribute binaries of JDK via adoptium. LoongArch code was based on openjdk 8, here is repo on github:https://github.com/loongson/jdk8u. LoongArch is a risc architecture, developed by Loongson Technology. Currently, the freetype version needs to be updated, see: #3120. So this pr can't be merged yet, it's just used to ask for your opinion in advance.

We intend to use jdk8 as a trial and look forward to participating in more adoptium community work.

Thanks

[karianna]

Hi @Panxuefeng-loongson - Are you able to sign the Eclipse CLA?

[karianna]

@Panxuefeng-loongson the Loongsoon build itself seems to be failing: https://github.com/adoptium/temurin-build/actions/runs/3327315068/jobs/5515528475

[Panxuefeng-loongson]

@Panxuefeng-loongson the Loongsoon build itself seems to be failing: https://github.com/adoptium/temurin-build/actions/runs/3327315068/jobs/5515528475

I only tested it on my local machine, I will fix the build failure in docker.

[Panxuefeng-loongson]

Hi @Panxuefeng-loongson - Are you able to sign the Eclipse CLA?

I clicked on this link: https://accounts.eclipse.org/user/register?destination=legal/eca/validation/125041 and want to register an account, an error occurred while submitting information: The answer you entered for the CAPTCHA was not correct. Could you please tell me where to sign the cla agreement?

[smlambert]

This has some guidance for ECA signing, hopefully it can help: https://adoptium.net/docs/eca-sign-off

[Panxuefeng-loongson]

Hi @Panxuefeng-loongson - Are you able to sign the Eclipse CLA?

I have signed the Eclipse CLA. Thanks for your help @karianna @smlambert

[smlambert]

ECA validation now passes 👍

[karianna]

Some minor changes, broadly looks good.

[Panxuefeng-loongson]

@theaoqi is our team leader, you can also ask him if you have any questions. Before merge this changes, I would like to ask @theaoqi to confirm the changes again.

[zdtsw]

Assume after we enable this feature (do nightly+weekly jdk8 build to support loongson), we need update ci-jenkins-pipeline as well

[karianna]

LGTM - Please note there is a separate decision whether to add build agents at Adoptium, but at least this should enable folks to build locally.

[theaoqi]

LGTM

[theaoqi]

Looks like the patch broke the builds? @Panxuefeng-loongson please have a look.

[Panxuefeng-loongson]

Some errors have occurred, i will check it

[tellison]

Why is the architecture check required? Doesn't it require a Loongson JVM to build the Loonson codebase every time?

[Panxuefeng-loongson]

Why is the architecture check required? Doesn't it require a Loongson JVM to build the Loonson codebase every time?

I found that in jenkins jobs, Loongson codebase will build on x86 machine. If not architecture check, x86 machine will use the LoongArch jdk binary, and an error will occur when VARIANT is BUILD_VARIANT_LOONGSON. Maybe my ideas are wrong and welcome to give your opinion.

[Panxuefeng-loongson]

Please review the change again and welcome to give your opinion @tellison @karianna

[andrew-m-leonard]

Looks good, thanks

[karianna]

Couple of shellcheck warnings:

...
2022-11-26 06:18:35 [INFO]   File:[/github/workspace/sbin/build.sh]
2022-11-26 06:18:37 [ERROR]   Found errors in [shellcheck] linter!
2022-11-26 06:18:37 [ERROR]   Error code: 1. Command output:
------

In /github/workspace/sbin/build.sh line 250:
        local updateNum="$(cat "$loongsonVerFile" | awk -F - '{print $1}' | awk -F u '{print $2}')"
                               ^----------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.


In /github/workspace/sbin/build.sh line 251:
        local buildNum="$(cat "$loongsonVerFile" | awk -F - '{print $2}')"
                              ^----------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.

For more information:
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...
------
...

[Panxuefeng-loongson]

Couple of shellcheck warnings:

...
2022-11-26 06:18:35 [INFO]   File:[/github/workspace/sbin/build.sh]
2022-11-26 06:18:37 [ERROR]   Found errors in [shellcheck] linter!
2022-11-26 06:18:37 [ERROR]   Error code: 1. Command output:
------

In /github/workspace/sbin/build.sh line 250:
        local updateNum="$(cat "$loongsonVerFile" | awk -F - '{print $1}' | awk -F u '{print $2}')"
                               ^----------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.


In /github/workspace/sbin/build.sh line 251:
        local buildNum="$(cat "$loongsonVerFile" | awk -F - '{print $2}')"
                              ^----------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.

For more information:
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...
------
...

I will fix this problem, thanks

[karianna]

LGTM

[Panxuefeng-loongson]

ping

[gdams]

@Panxuefeng-loongson this looks good to me, on the topic of FreeType, I propose that we merge #3188 first which would then allow us to specify a different FreeType tag for Loongson JDK. What do you think?

[Panxuefeng-loongson]

@Panxuefeng-loongson this looks good to me, on the topic of FreeType, I propose that we merge #3188 first which would then allow us to specify a different FreeType tag for Loongson JDK. What do you think?

This option looks great and I agree with your solution

[gdams]

Out of interest, what FreeType version does Loongson JDK need @Panxuefeng-loongson?

[Panxuefeng-loongson]

Out of interest, what FreeType version does Loongson JDK need @Panxuefeng-loongson?

Recent versions of freetype have met the Loongson JDK build, because config.guess and config.sub support LoongArch from this point onwards: http://git.savannah.gnu.org/gitweb/?p=config.git;a=commit;h=c8ddc8472f8efcadafc1ef53ca1d863415fddd5f, It's been two years since. I have checked the last few versions of freetype and they all meet our needs. Thanks @gdams

[andrew-m-leonard]

this has been stale for over a year, converting to "draft", if no longer needed please close.