Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: add commit for robot model collision features back #187

Merged
merged 12 commits into from
Apr 25, 2024
Merged

revert: add commit for robot model collision features back #187

merged 12 commits into from
Apr 25, 2024

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Apr 17, 2024 •
edited
Loading

Description

Painful but here are the commits back that would give version 8.0.0

Review guidelines

Estimated Time of Review: 5 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8
Revert "Revert "feat(build): handle installation and linking of depen…
67bd73b 
…dencies for pinocchio collision support (#161)""

This reverts commit 999bad7.
@domire8
Revert "Revert "build: add missing licenses (#170)""
e8c92af 
This reverts commit 6f93944.
@domire8
Revert "Revert "ci: use caching from docker to run test in CI (#169)""
54f86d8 
This reverts commit 90c959a.
@domire8
Revert "Revert "feat: integrate collision detection feature into robo…
f6e69f6 
…t model (#163)""

This reverts commit a83d1a3.
@domire8
Revert "Revert "ci: update workflows (#175)""
faf15bc 
This reverts commit 4158f34.
@domire8
Revert "Revert "feat: Integrate min distance (#167)""
7bc4d28 
This reverts commit 565e3b1.
@domire8
Revert "Revert "fix: refactor cmake project to deal with robot model …
97941c5 
…dependencies (#178)""

This reverts commit 6402408.
@domire8
Revert "Revert "refactor: optimize copy and swap constructors for rob…
cb10e41 
…ot_model::Model (#177)""

This reverts commit 272f048.
@domire8
Revert "Revert "build: remove deprecated Dockerfiles and scripts and …
f984d5f 
…update installation instructions (#176)""

This reverts commit fb7c9e9.
@domire8
Revert "Revert "fix: update copy constructor to avoid warnings (#180)""
9241350 
This reverts commit 099c8e1.
@domire8
Revert "Revert "feat: update demos directory (#179)""
a589474 
This reverts commit 486367b.
@domire8
Revert "Revert "chore: touch up workflows and documentation (#181)""
2f0d5e7 
This reverts commit 789eb41.
@domire8
Copy link
Member Author

domire8 commented Apr 23, 2024 •
edited
Loading

I can't be 100% sure but it seems from my tests that everything is good with v7.4.0 so we could bring these commits back and release 8.0.0

@domire8 domire8 merged commit 2ac9feb into develop Apr 25, 2024
5 checks passed
@domire8 domire8 deleted the revert/revert branch April 25, 2024 06:05
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eeberhard eeberhard eeberhard approved these changes

@bpapaspyros bpapaspyros Awaiting requested review from bpapaspyros

@yrh012 yrh012 Awaiting requested review from yrh012

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domire8 @eeberhard