Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metadata to docker image #188

Merged
merged 2 commits into from
Apr 30, 2024
Merged

feat: add metadata to docker image #188

merged 2 commits into from
Apr 30, 2024

Conversation

LouisBrunner
Copy link

@LouisBrunner LouisBrunner commented Apr 30, 2024

Description

Part of https://github.com/aica-technology/ops/issues/333

@domire8 what's the process to release this library?

Review guidelines

Estimated Time of Review: 4 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@LouisBrunner LouisBrunner self-assigned this Apr 30, 2024
@domire8
Copy link
Member

domire8 commented Apr 30, 2024

There are currently breaking changes on the develop branch, so we should release 8.0 first probably.

@domire8
Copy link
Member

domire8 commented Apr 30, 2024

I'd prefer to do the 8.0 release, then get rid of develop and then bring this here in and we can tag it as 8.0.1

@LouisBrunner
Copy link
Author

I don't see why we should wait as this shouldn't impact anything but if you prefer to do it this way I don't mind

Copy link
Member

@domire8 domire8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright bring it in, I'll rebase 8.0

@LouisBrunner LouisBrunner merged commit 61b0cda into develop Apr 30, 2024
5 checks passed
@LouisBrunner LouisBrunner deleted the feat/meta branch April 30, 2024 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants