11.0 helpdesk improvement

[AlhMaria]

Added a new module called helpdesk_improvement.

In this module has been added:

• BlackList
  

• WhiteList
  

• BlackList settings
  

[codecov-io]

Codecov Report

Merging #13 into 11.0 will decrease coverage by 0.43%.
The diff coverage is 62.5%.

@@            Coverage Diff             @@
##             11.0      #13      +/-   ##
==========================================
- Coverage   66.25%   65.81%   -0.44%     
==========================================
  Files           9       11       +2     
  Lines         243      275      +32     
==========================================
+ Hits          161      181      +20     
- Misses         82       94      +12

Impacted Files	Coverage Δ
...elpdesk_improvement/models/helpdesk_improvement.py	100% <100%> (ø)
helpdesk_improvement/models/res_config.py	36.84% <36.84%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd0b46...d601b5b. Read the comment docs.

[aitorbouzas]

You're messing with commit history. Do you see how in files changed everything is green? That means you are doing something wrong.

[AlhMaria]

Yes, the files in files changed are green because I added a new module, helpdesk_improvement, so I'm creating all files from the start.

[aitorbouzas]

Oh! Sorry, didn't notice. I'm so tired yet...
In that case i'll review soon. Fast first review:

1. helpdesk_improvement is not a descriptive name. This should be called helpdesk_blacklist_whitelist IMO.
2. You add models and config, but where's the behaviour of stopping incoming blacklisted tickets? And where's the behaviour of atuomatically adding a email to blacklist?
3. Models shouldn't be helpdesk.ticket.blacklist.line and helpdesk.ticket.whitelist.line. They simply should be helpdesk.ticket.blacklist and helpdesk.ticket.whitelist.
4. Manifest file looks like it was copy/pasted. We are not the authors, in this case the author is just you. Also this is not an application.

Ping @carlosDomatix for reviewing help.