fix: note links note being replaced correctly when keepEvernoteLinkIfNoNoteFound = true (#653) #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NoNoteFound = true (akosbalasko#653) The original regexes were greedy, which would wipe out many links on the same line, but also the resulting link still contains the original Evernote link, it wasn't getting replaced at all. I updated the intermediate <YARLE_EVERNOTE_LINK> format to contain the original note id to guarantee a correct match, then replace the link format approariately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #653
The original regexes were greedy, which would wipe out many links on the same line, but also the resulting link still contains the original Evernote link, it wasn't getting replaced at all. I updated the intermediate <YARLE_EVERNOTE_LINK> format to contain the original note id to guarantee a correct match, then replace the link format appropriately.