Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: note links note being replaced correctly when keepEvernoteLinkIfNoNoteFound = true (#653) #656

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: note links note being replaced correctly when keepEvernoteLinkIfNoNoteFound = true (#653) #656

wants to merge 1 commit into from

Commits on Nov 21, 2024

  1. fix: note links note being replaced correctly when keepEvernoteLinkIf… 

    …NoNoteFound = true (akosbalasko#653)

The original regexes were greedy, which would wipe out many links on the same line,
but also the resulting link still contains the original Evernote link, it wasn't getting replaced at all.
I updated the intermediate <YARLE_EVERNOTE_LINK> format to contain the original note id
to guarantee a correct match, then replace the link format approariately.
    @bumper314
    bumper314 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    15e0cf5 View commit details
    Browse the repository at this point in the history