-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new environment for annotation #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The environment doesn't install 🥲
grace
needs to get out of the .yaml
The installation takes an entire forever. Any tricks to speed it up?
environment_annotation.yml
Outdated
- fonttools==4.40.0 | ||
- google-auth==2.21.0 | ||
- google-auth-oauthlib==1.0.0 | ||
- grace==0.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the environment gets confused when instructed to install grace, which is not on pip
just yet.
Pip subprocess error:
ERROR: Could not find a version that satisfies the requirement grace==0.0.1 (from versions: ... )
ERROR: No matching distribution found for grace==0.0.1
failed
CondaEnvException: Pip failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something we need to keep changing whenever we make a new environment (because we install grace with the pip . -e, it considers grace a "pip installed" package)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine to do so, given that README.md has all the detailed instructions.
environment_annotation.yml
Outdated
- torchvision==0.15.2 | ||
- urllib3==1.26.16 | ||
- werkzeug==2.3.6 | ||
prefix: /Users/bcostagomes/anaconda3/envs/test_grace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the prefix belong in the env.yaml
?
README.md
Outdated
@@ -92,14 +93,32 @@ pre-commit install | |||
|
|||
``` | |||
|
|||
For the annotation, use the following lines to load and activate that correct environment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to explicitly explain to the users what they will and won't be able to do when using either environment. I'm happy to change the README.md afterwards, there are other documentation issues that need to be added 😃
…ix, added README further explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better, the environment gets created and annotation in napari works. The main README.md is slightly confusing - I'll add more installation instructions in the upcoming PR, renaming the envs. This new env is ready to merge 🚀
|
||
```sh | ||
# create the playground from environment_annotation.yml | ||
conda env create -f environment_annotation.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda env create -f environment_annotation.yaml
needs to become
conda env create -f environment_annotation.yml
otherwise the file is not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix this in the follow-up README.md update
Solves #135