Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new environment for annotation #139

Merged
merged 2 commits into from
Aug 23, 2023
Merged

new environment for annotation #139

merged 2 commits into from
Aug 23, 2023

Conversation

mooniean
Copy link
Collaborator

Solves #135

Copy link
Collaborator

@KristinaUlicna KristinaUlicna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment doesn't install 🥲
grace needs to get out of the .yaml
The installation takes an entire forever. Any tricks to speed it up?

- fonttools==4.40.0
- google-auth==2.21.0
- google-auth-oauthlib==1.0.0
- grace==0.0.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the environment gets confused when instructed to install grace, which is not on pip just yet.

Pip subprocess error:
ERROR: Could not find a version that satisfies the requirement grace==0.0.1 (from versions: ... )
ERROR: No matching distribution found for grace==0.0.1

failed

CondaEnvException: Pip failed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something we need to keep changing whenever we make a new environment (because we install grace with the pip . -e, it considers grace a "pip installed" package)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to do so, given that README.md has all the detailed instructions.

- torchvision==0.15.2
- urllib3==1.26.16
- werkzeug==2.3.6
prefix: /Users/bcostagomes/anaconda3/envs/test_grace
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the prefix belong in the env.yaml?

README.md Outdated
@@ -92,14 +93,32 @@ pre-commit install

```

For the annotation, use the following lines to load and activate that correct environment:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to explicitly explain to the users what they will and won't be able to do when using either environment. I'm happy to change the README.md afterwards, there are other documentation issues that need to be added 😃

@KristinaUlicna KristinaUlicna self-requested a review August 23, 2023 16:47
Copy link
Collaborator

@KristinaUlicna KristinaUlicna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, the environment gets created and annotation in napari works. The main README.md is slightly confusing - I'll add more installation instructions in the upcoming PR, renaming the envs. This new env is ready to merge 🚀


```sh
# create the playground from environment_annotation.yml
conda env create -f environment_annotation.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conda env create -f environment_annotation.yaml
needs to become
conda env create -f environment_annotation.yml
otherwise the file is not found

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix this in the follow-up README.md update

@KristinaUlicna KristinaUlicna merged commit 25c2dee into main Aug 23, 2023
1 check passed
@KristinaUlicna KristinaUlicna deleted the dev_environment branch August 23, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants