Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actionlint and factor out its config into a reusable action. #1360

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

sengi
Copy link
Contributor

@sengi sengi commented Jun 28, 2024

So we don't have to update the version pinning etc. across multiple repos, since I'm about to add it to alphagov/govuk-ruby-images.

The actionlint check failure on this PR is expected (because the reusable action won't exist on main until this PR is merged).

Tested: check passes when pointing at the PR branch for the reusable action: https://github.com/alphagov/govuk-infrastructure/actions/runs/9716231768/job/26819399056#step:3:31

#1361

sengi added 3 commits June 28, 2024 18:00
This lets us keep the version pinning and config in a single place while
using actionlint in other repos.
The install script defaults to the current version and we're already
pinning the commit sha of the install script.
@sengi sengi force-pushed the sengi/actionlint branch from ddbc040 to e334fe0 Compare June 28, 2024 17:00
@sengi sengi merged commit f86867b into main Jul 3, 2024
1 of 2 checks passed
@sengi sengi deleted the sengi/actionlint branch July 3, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants