Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump carrierwave from 3.0.5 to 3.0.7 #9634

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 20, 2024

Bumps carrierwave from 3.0.5 to 3.0.7.

Release notes

Sourced from carrierwave's releases.

3.0.7

Security

3.0.6

Fixed

Changelog

Sourced from carrierwave's changelog.

3.0.7 - 2024-03-23

Security

3.0.6 - 2024-03-09

Fixed

Commits
  • cf2f011 Version 3.0.7
  • 00676e2 Fix Content-Type allowlist bypass vulnerability remained
  • a18e13c Version 3.0.6
  • 5653c25 Fix ruby-head build
  • 46e4f20 Fix #derived_versions and #active_sibling_versions returning an Array where H...
  • 78845ea Merge pull request #2728 from schinery/main
  • 4c65b39 Fix assigning a file with the same name not marking the column as changed
  • 63113e9 Fix failing to remove files with ActiveRecord 7.1 after_commit order change e...
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Nov 20, 2024
Copy link

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

Bumps [carrierwave](https://github.com/carrierwaveuploader/carrierwave) from 3.0.5 to 3.0.7.
- [Release notes](https://github.com/carrierwaveuploader/carrierwave/releases)
- [Changelog](https://github.com/carrierwaveuploader/carrierwave/blob/master/CHANGELOG.md)
- [Commits](carrierwaveuploader/carrierwave@v3.0.5...v3.0.7)

---
updated-dependencies:
- dependency-name: carrierwave
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/carrierwave-3.0.7 branch from 574a818 to 9e4cca1 Compare November 21, 2024 16:48
@minhngocd minhngocd force-pushed the dependabot/bundler/carrierwave-3.0.7 branch from f9d01fb to f4505f6 Compare November 22, 2024 15:55
Copy link
Contributor

@lauraghiorghisor-tw lauraghiorghisor-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test can go, I think. But up to you.

Filename check LGTM.

Carrierwave has introduced a new temporary cache ID to its carrierwave_file names to force trigger a file update if users upload a file with the same name. This has then broken our asset comparison checks since we rely on these filenames to check whether or not the assets have been updated in assets manager, and the filename no longer matches. We are switching to use filename instead, which is the same value we send to Asset Manager for a more consistent check

We could use these temporary cache IDs to our advantage to differentiate between files with the same name, but unfortunately this gets stripped upon saving, and hence will not be available after commit. Not a consistent value to depend on. It may also affect readability of the generated URL filepaths

Simplifying logic of asset checking

Instead of relying on splitting, we could just use the filename that we actually pass through to asset manager to do the checks
@minhngocd minhngocd force-pushed the dependabot/bundler/carrierwave-3.0.7 branch from f4505f6 to 3e16bcc Compare November 22, 2024 16:29
@minhngocd minhngocd merged commit 4068f01 into main Nov 22, 2024
19 checks passed
@minhngocd minhngocd deleted the dependabot/bundler/carrierwave-3.0.7 branch November 22, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants