Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding inverse kinematic controller #9

Merged
merged 17 commits into from
May 3, 2024
Merged

Adding inverse kinematic controller #9

merged 17 commits into from
May 3, 2024

Conversation

CarlottaSartore
Copy link
Collaborator

This PR include the inverse kinematic controller and the related example to make the robot walk, in position control, using bipedal locomotion inverse kinematic, centroidal MPC and mujoco simulator.
It depends on bipedal locomotion framework version 0.16

@CarlottaSartore CarlottaSartore marked this pull request as draft January 10, 2024 15:40
@CarlottaSartore CarlottaSartore self-assigned this Jan 10, 2024
@CarlottaSartore
Copy link
Collaborator Author

This PR is still a draft, because we need to understand how to automatically add tag to the contacts in mujoco for the feet rear and front.

@CarlottaSartore
Copy link
Collaborator Author

This PR is still a draft, because we need to understand how to automatically add tag to the contacts in mujoco for the feet rear and front.

This has been solved in 25ada23 , but there are still some issues in the computation of the wrenches that I want to furtherly investigate before resolving the draft status

@CarlottaSartore CarlottaSartore marked this pull request as ready for review April 17, 2024 10:36
@CarlottaSartore
Copy link
Collaborator Author

I have decided to add in a future a PR solely for the examples. thus now this PR is ready for review.

The problem with the wrenches has been solved.
In addition we have added:

  • Automatic load of meshes
  • Automatic mapping in between input joint name list and mujoco order

Copy link
Contributor

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

README.md Show resolved Hide resolved
src/comodo/robotModel/robotModel.py Outdated Show resolved Hide resolved
@S-Dafarra
Copy link
Member

Nit. kinematic is and adjective, while kinematics is a noun. In this case I think it should be InverseKinematics

Copy link
Member

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments on the notebook

examples/mujoco_walking_position.ipynb Show resolved Hide resolved
examples/mujoco_walking_position.ipynb Outdated Show resolved Hide resolved
examples/mujoco_walking_position.ipynb Outdated Show resolved Hide resolved
examples/mujoco_walking_position.ipynb Show resolved Hide resolved
examples/mujoco_walking_position.ipynb Outdated Show resolved Hide resolved
examples/mujoco_walking_position.ipynb Show resolved Hide resolved
examples/mujoco_walking_position.ipynb Outdated Show resolved Hide resolved
src/comodo/inverseKinematic/inverseKinematicParamTuning.py Outdated Show resolved Hide resolved
src/comodo/mujocoSimulator/mujocoSimulator.py Outdated Show resolved Hide resolved
src/comodo/mujocoSimulator/mujocoSimulator.py Outdated Show resolved Hide resolved
src/comodo/robotModel/robotModel.py Show resolved Hide resolved
src/comodo/robotModel/robotModel.py Show resolved Hide resolved
CarlottaSartore and others added 5 commits April 17, 2024 16:39
Co-authored-by: Stefano Dafarra <stefano.dafarra@gmail.com>
Co-authored-by: Stefano Dafarra <stefano.dafarra@gmail.com>
Co-authored-by: Stefano Dafarra <stefano.dafarra@gmail.com>
Co-authored-by: Stefano Dafarra <stefano.dafarra@gmail.com>
@CarlottaSartore
Copy link
Collaborator Author

@S-Dafarra I think I resolve all your comments, let me know if there is something I have missed

@CarlottaSartore
Copy link
Collaborator Author

Thanks all ! Merging !

@CarlottaSartore CarlottaSartore merged commit a15d957 into main May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants