-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CODEOWNERS and migrate to pyproject.toml #47
Conversation
80dcbbc
to
c8348f2
Compare
c8348f2
to
91072a1
Compare
91072a1
to
4e9a386
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @flferretti! I just want to let all of you know that, despite I will no longer be among the codeowners since I'm leaving IIT, I still plan to use -and possibly, contribute- to the project. I'll keep an eye to the PRs, expect some occasional review / random comment. On your end, feel free to tag me in any issue / PR, but feel free to proceed even without my feedback.
requires-python = ">= 3.10" | ||
description = "The ultimate Python tool for RObot Descriptions processing." | ||
authors = [ | ||
{ name = "Diego Ferigo", email = "dgferigo@gmail.com" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is always a fine line between who is author and who not, but I guess that Filippo and Lorenzo having contributed ~36 and ~20 commits each perhaps can be listed as authors as well? fyi @diegoferigo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me the author is who created the project and developed most of its core, contributors are those that contributed with minor features, and maintainers those that are actively taking care of chores and possibly contributing with minor features (but not necessarily). What do you think?
Feel free to adjust the README accordingly (note that github already shows in the right panel the contributors). PyPI metadata has only authors/maintainers. Contributors generally can be gathered from github. Usually for external people, it's more important reaching out through email only the original author / current maintainer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me, I typically always consider the maintainers team a subset of the authors teams, but that is just personal preference, but I do not strongly feel about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, just to clarify, the role of a maintainer -as I see it- is more loose. It can either be one of the authors (in case of major contributions), one of the contributors (in case of minor contributions), or just a maintainer (in case of just chores).
Introduce a CODEOWNERS file for better collaboration and remove setup.cfg in favor of pyproject.toml for improved project configuration and updated maintainers